-
Notifications
You must be signed in to change notification settings - Fork 23k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gitsigns essential keymaps #779
Conversation
LGTM but I'll defer to @tjdevries as I haven't had a problem with this stuff from jump, but can appreciate the desire to keep things small and understandable. |
Hi! Just wanted to mention what I did and ask if this might be a good option for you: If I install gitsigns like a regular old plugin, I get it in all its full fat goodness. Keymaps, configs. The whole enchilada. Why not just do that? What am I missing? That way @tjdevries can get his super minimal starting point for new folks, and we can enjoy our luxurious git manipulating goodness in our forks? :) Sorry if I'm missing something obvious, and in NO way do I mean to cut down the value of all your amazing contributions and work on this project. You really have been an outstanding contributor, and I for one sincerely appreciate it! Should you ever come to Boston, MA, USA. Please do look me up! I'd love to buy you a beverage or dinner or whatever :) |
@feoh your suggestion works. But I think it's not clean that a plugin has the spec split into two files. Please open a PR with your solution so there are more options for TJ to pick from. It's not a question what works for me, I have the full enchilada no worries, the question is what is the best for the average or new Neovim user. I think a new Neovim user isn't necessarily a fresh developer, he can be an experienced developer looking for a new editor. A perfect example: DHH moving to Neovim: https://twitter.com/dhh/status/1764340531877105824 Anyway let's wait for @tjdevries feedback and we'll see. And thanks for the kind words, I have no travel plans to US at the moment, but I'll keep it in mind :) |
0a14bf8
to
5a95462
Compare
Just coming back to this in my usual PR check: I don't know that generating a PR of my change is appropriate because my change has the gitsigns plugin installed in lua/custom/plugins which I think we'd prefer to reserve for end users to fill themselves :) |
Gitsigns has just updated and |
Include essential gitsigns keymaps, for more see gitsigns README: https://github.com/lewis6991/gitsigns.nvim
5a95462
to
a57a176
Compare
Closed in favor of #858. Thanks for the hard work on this! |
An alternative attempt at including only the essential keymaps compared to the full list in: #740
Changes compared to the full list:
(re)Add gitsigns recommended keymaps #740 (review)
Compared to the original PR this one has about half the lines of code, hopefully this will make it more likely to be included.