Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add support for mini.icons #1510

Closed
wants to merge 2 commits into from

Conversation

mehalter
Copy link
Contributor

@mehalter mehalter commented Jul 5, 2024

This adds support for mini.icons for providing icons for not just files but also directories

2024-07-05_10:09:40_screenshot

@miversen33
Copy link
Collaborator

I maybe making this a bigger thing than it should be, but this PR makes me wonder if we should simply allow for the user to supply an "icon" function that we can call to get the icon for a node.

I can easily see a future where more icon packs come out and we end up having to support xyz icon packs and its done via nasty "if/elseif" logic.

I don't imagine it would be super hard to do this either as we already have some logic in place for getting the icon for a node in the components (like you are doing now with this).

That is just my 2cents though, I could also see the argument that it's not important, or a user can already do that if they want.

@mehalter
Copy link
Contributor Author

I actually really like this idea. Let me revise this PR and make a recommendation for a general system that can work here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants