anchor definition not concealed when conceallevel=2

[champignoom]

Prerequisites

• I am using the latest stable release of Neovim
• I am using the latest version of the plugin

Neovim Version

v0.9.0

Neorg setup

require('neorg').setup {
	load = {
		["core.defaults"] = {}, -- Loads default behaviour
		["core.norg.concealer"] = {}, -- Adds pretty icons to your documents
		["core.norg.dirman"] = { -- Manages Neorg workspaces
			config = {
				workspaces = {
					notes = "~/notes",
				},
			},
		},
	},
}

Actual behavior

It becomes:

{* heading}

Expected behavior

It should remain:

{◉ heading}

Steps to reproduce

test.norg:

{* heading}

By entering normal mode, it's concealed to

{◉ heading}

Now :set conceallevel=2

Potentially conflicting plugins

No response

Other information

No response

Help

Yes

Implementation help

No response

[champignoom]

Ok I just found out that "no-conceal" might be intended for link targets:

neorg/lua/neorg/modules/core/concealer/module.lua

Line 1103 in 6aa9fd3

query = "[ (heading1_prefix) (link_target_heading1) @no-conceal ] @icon",

But then the problem becomes that it does get concealed when conceallevel != 2. The and has_conceal part below looks suspicious.

neorg/lua/neorg/modules/core/concealer/module.lua

Lines 118 to 122 in 6aa9fd3

	if capture == "no-conceal" and has_conceal then
	nodes_to_omit[node:id()] = true
	end
	if capture == "icon" and not nodes_to_omit[node:id()] then

[vhyrro]

This is intended, when vim's concealing is enabled then there's no way to place the extmark, otherwise the icon overlays the concealed text, which looks like this: ◉eading. There's no way we can implement "reconcealing" on every cursor move, otherwise the entire Neovim instance would very quickly slow down to a crawl.

When you don't hide the text, the concealer will display the icon, as it knows it will never break anything. Otherwise, it just doesn't bother rendering at all.

Closing since this is intended behaviour :)

[champignoom]

This is now fixable with #834.

[champignoom]

but the fix might trigger a neovim bug neovim/neovim#23706
EDIT: that bug has been fixed