fix: record that module upgrade requires at least 1 arg
#1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t ui.select goes off At /neorg/lua/neorg/modules/core/neorgcmd/module.lua:258, a check is performed to ensure that at least the minimum number of arguments have been provided for the given module. The core module `upgrade` currently does not set this property at all, resulting in an error when attempting to call `:Neorg upgrade`. By communicating that `upgrade` requires at least 1 arg, `neorgcmd` will be able to call the function `select_next_cmd_arg` at line 260.
|
Wait luacheck failed on files I did not even touch. Did I mess something up? |
|
Thank you for the fix! Don't worry about the failing checks, those are coming from a different source |
vhyrro
changed the title
bugfix: Record that module upgrade requires at least 1 argupgrade requires at least 1 arg
benlubas
pushed a commit
to benlubas/neorg
that referenced
this pull request
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1206
The purpose is to ensure that
neorgcmdcan launch the ui selector when the user doesn't provide the necessary arguments to theupgrademodule.At
/neorg/lua/neorg/modules/core/neorgcmd/module.lua:258, a check is performed to ensure that at least the minimum number of arguments have been provided for the given module. The core moduleupgradecurrently does not set thismin_argsproperty at all, resulting in an error when attempting to call:Neorg upgrade. By communicating thatupgraderequires at least 1 arg,neorgcmdwill be able to call the functionselect_next_cmd_argat line 260.