fix: neovim 0.9 vim.treesitter.parse_query deprecation #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagua
force-pushed
the
update-neovim-treesitter-api
branch
from
4cc4c3b
to
70e714c
Compare
max397574
reviewed
Mar 27, 2023
lua/neorg/external/helpers.lua
Outdated
| --- @param query_string string # Query in s-expr syntax | ||
| --- @return any # Parsed query | ||
| ts_parse_query = function(language, query_string) | ||
| if vim.fn.has("nvim-0.9") == 1 then |
There was a problem hiding this comment.
checking like this will break things for people with an outdated nightly (like me)
you should do if vim.treeistter.query.parse then
…in nightly compatibility
|
Thanks a lot for the PR! Fixed that bit that max was talking about and now we should be good :) |
vhyrro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
neovim 0.9 deprecated the
vim.treesitter.parse_querycall a few days ago.You should now use
vim.treesitter.query.parseinstead.I introduced a new
neorg.utils.ts_parse_queryfunction that will check theneovim version used and use the right call. I replaced all usage of
parse_querywith the new function.
Have a great day everyone!