additions to grammarPlugins should be passed through grammarToPlugin #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerchunPak
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Should unblock updates for multiple users, see NixOS/nixpkgs#356274
|
Yeah that was the issue I was having can confirm this is the fix. Have been using my branch since I fixed it here and it works |
|
note: tests on main fail |
|
Ah.... Ok... Well, thats cause its looking in the wrong spot now... Didnt think about that. It works now though! |
|
the only one failing is nvim failing to create an ftdetect for neorg plugin, not for the grammar. Im not sure that case is even actually testing the grammars but rather neorg plugin itself and nvim? It might be ok to just remove that, but regardless its hard to be 100% sure that its because of the grammars |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10 (a build failure, doesnt work at all until the PR goes through)