-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current development branch #35
Open
mrossinek
wants to merge
6
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 11, 2022
Closed
mrossinek
commented
Feb 11, 2022
mrossinek
commented
Feb 11, 2022
mrossinek
commented
Feb 11, 2022
mrossinek
commented
Feb 11, 2022
mrossinek
commented
Feb 11, 2022
mrossinek
commented
Feb 24, 2022
mrossinek
commented
Feb 26, 2022
This was referenced Apr 3, 2022
Closed
This grammar generation is still quite the mess but I have not found a better way yet... The parser size is now at 33MB but we have quite some odd cases here. Especially problematic is the nesting levels being coupled between the parent object of the slide and its contents. E.g.: ```norg -- : > this does not work because the outer list item is level 2, so the inner quote item also needs to be at least that level ``` Also: ```norg > : --- this also does not work because allowing arbitrary nesting levels in here results in *absolutely frickin massive* parsers 😱 ``` I think we need to figure out a better way on how to deal with infectability if we want to implement this properly.
The last clause was overriding defaultPackage with its system-specific attributes completely. Instead of `nix build --impure .`, the impure making builtins.currentSystem available, users should now be able to simply `nix build .` and make the flake importable in pure contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidates the work on:
paragraph
parsing refactoring ([ON HOLD] Prep 0.0.11 #30)