feat(archive): set outline path when archiving #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaswachowski
force-pushed
the
add-olpath-to-archive-context
branch
from
48625e7
to
eb5109c
Compare
andreaswachowski
force-pushed
the
add-olpath-to-archive-context
branch
from
eb5109c
to
04a50de
Compare
|
@kristijanhusak do you have any concern with this PR? It sounds quite useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the outline path (
ARCHIVE_OLPATH, i.e. the list of ancestors of the archived headline) to the archive context. In Emacs, seeThis PR includes a fix to set the
ARCHIVE_TODOattribute as well.I checked with Emacs first and then specified the test to match what Emacs does. Looking forward to any feedback you might have!