Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(path_display): move lnum/col next to filename for filename_first #3200

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jamestrew
Copy link
Contributor

@jamestrew jamestrew commented Jul 9, 2024

Combines transform_devicons, transform_path and the string formatting of line and column numbers when available as create_path_display.

This offers a few benefits:

@jamestrew jamestrew force-pushed the filename-first-coordinates branch from 2b3da84 to 9c22df6 Compare July 10, 2024 01:14
@jamestrew jamestrew force-pushed the filename-first-coordinates branch 8 times, most recently from f14e8be to c6b45a9 Compare July 10, 2024 14:17
@jamestrew jamestrew marked this pull request as ready for review July 10, 2024 18:48
@jamestrew
Copy link
Contributor Author

I've done some testing with some of the common pickers (find_files, live_grep, grep_string, buffers, diagnostics, lsp_[references/definition]).
I'm going to keep riding this branch for a bit.

@jamestrew jamestrew force-pushed the filename-first-coordinates branch 2 times, most recently from d72adb0 to bfbc512 Compare July 21, 2024 18:47
@jamestrew jamestrew force-pushed the filename-first-coordinates branch from 29a9d38 to a8954e1 Compare July 21, 2024 18:49
@Daydreamer-riri
Copy link

This function is great! Looking forward to the merger. Thanks for your great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants