Allow passing env to new_termopen_previewer
#3224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm trying to use difft for a custom picker and regular git diff on another.
Using the global
set_env
for telescope becomes too aggressive, just like inutils.job_maker
I'd like to be able to passenv
in the same format to do this:Since it's a term command, being able to pass custom envs seems appropriate, the implementation is trivial and similar to what's done in
utils.job_maker
.Type of change
How Has This Been Tested?
set_env = { GIT_EXTERNAL_DIFF = '~/.local/bin/difft' }
, see difft diffset_env
, see regular diffset_env = { GIT_EXTERNAL_DIFF = '~/.local/bin/difft' }
, see difft diffset_env
, see regular diffset_env
, passing no opts, see regular diffset_env
, passingopts.env = { GIT_EXTERNAL_DIFF = '~/.local/bin/difft' }
, see difft diffConfiguration:
Checklist:
Ps.
Create draft to see if CI adds docs to my PR, reworks #3223
Pps.
Any ideas on why the docs aren't changing?