feat: add cursor layout

[Luxed]

Closes #496.

Here's how it looks like when space is not an issue, my cursor is on the first "t" of the "test" variable name:

Here's how it looks like when space is restricted in the bottom right (cursor at the same place):

What happens when there is not enough room is that the floating window gets put above the cursor line and gets fixed to the right (with 1 extra space to give it some room).

[dhruvmanila]

Nice job! Are you calculating the corner the window should be anchored to? Like in floating windows either one of the corners (NW, NE, SW, SE) is made an anchor point to the cursor. This is calculated using the space available for the telescope window w.r.t. the main Neovim window. You might want to take a look at vim.lsp.util.make_floating_popup_options()

Also, I think the layout updates should be put on hold for now until #823 is finalized and merged.

[Luxed]

Nice job! Are you calculating the corner the window should be anchored to? Like in floating windows either one of the corners (NW, NE, SW, SE) is made an anchor point to the cursor.

I am calculating the position so that the cursor is above the NW corner.
If the size of the floating window would be bigger than the available width, I then anchor it to the right of the screen (leaving 1 character of space).
If the size of the floating window would be bigger than the available height, I then anchor the bottom of the floating window above the cursor line.

Maybe it would be better for the window to always anchor to the NW, NE and SE points?

You might want to take a look at vim.lsp.util.make_floating_popup_options()

I remember looking into it, but it was so long ago that I'll look into it again.

Also, I think the layout updates should be put on hold for now until #823 is finalized and merged.

Of course, I didn't see this was ongoing.

[l-kershaw]

@Luxed just a heads up that #823 has now been merged (or at least its successor #922 has), so this PR is no longer blocked.

If you need any help with the new layout_config stuff, feel free to ping me 🙂

[Luxed]

@Luxed just a heads up that #823 has now been merged (or at least its successor #922 has), so this PR is no longer blocked.

If you need any help with the new layout_config stuff, feel free to ping me slightly_smiling_face

It ended up being a lot easier than I expected. Everything is working as it did before now.

[l-kershaw]

One small nitpick/question regarding preview_width, but overall looks very good 🙂

[l-kershaw]

I think I'm happy with this now 👍

I'll run this PR for a little bit and if I don't find any problems I'll merge this later today/tomorrow.

[mawkler]

This looks awesome. How do I tell vim.lsp.buf.code_action() to use this layout?

[gegoune]

@Melkster https://github.com/nvim-telescope/telescope-ui-select.nvim

[mawkler]

@gegoune Thanks!