-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Add new node selection action based on tab :drop command #2161
Conversation
2fd26f3
to
9488df5
Compare
@alex-courtis Please merge asap! |
9488df5
to
6040689
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have updated docs a bit and resolved styling.
Thanks for your contribution.
@gegoune I think we should provide and example somewhere in docs. Otherwise it's a black box for unfamiliar people. |
I am not against examples of course, is just that this one was not well placed. Other api don't provide any examples at all and this is what it should stay as. We can provide some example api usages on top of api help, more generic ones. |
@gegoune But where should such docs be placed? |
Actually there is already an example of how to use API functions in |
API would be great! |
@gegoune Well, it doesn't say explicitly that nvim-tree.lua/doc/nvim-tree-lua.txt Lines 1757 to 1777 in bb375fb
|
It shouldn't list all the available namespaces, This is out of topic here now. If you think documentation can be improved please open new issue or better yet a PR. |
@ |
Well I could have made an improvement via this PR, but anyway. |
That wasn't what we wanted to add to docs. Please open new issue if you want to continue this conversation. |
How about we just add a Recipe ? The :help is factual and correct. |
NvimTree.Drop.selection.demo.mov
<CR>
is hit, the same buffer window of the file is focused.Demo link:
https://user-images.githubusercontent.com/8136158/233742234-c4f4bb4b-1927-4ab4-b0cc-779c64a0e1b1.mov
PRs
PREVIOUS PRs got CLOSED BECAUSE OF FORCE-PUSH, GITHUB IS REALLY NUTS
Usage example