Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terraform icons #174

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Add terraform icons #174

merged 1 commit into from
Nov 14, 2022

Conversation

and3rson
Copy link
Contributor

@and3rson and3rson commented Nov 14, 2022

This PR adds icons for .tf and .tfvars.

I considered nf-fae-mountains () vs nf-mdi-terrain (行) but decided to use the former since it's only 1 character wide.

image

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Your timing is excellent as I am doing some work with terraform right now...

@alex-courtis alex-courtis merged commit 3b1b794 into nvim-tree:master Nov 14, 2022
@lanox
Copy link

lanox commented Nov 14, 2022

Thanks for this, I was wondering is there reason why we didn't go with normal terraform icons, like the ones that vscode uses?

@alex-courtis
Copy link
Member

Thanks for this, I was wondering is there reason why we didn't go with normal terraform icons, like the ones that vscode uses?

Is there a registry of "normal icons"? It might be nice to sync with standards...

@T-727
Copy link
Contributor

T-727 commented Nov 15, 2022

Assuming I understood correctly, @lanox
This plugin relies on nerd fonts for it's icons, if they don't provide an icon we can't add it.
You can request it on their github but it's likely in their roadmap.

@lanox
Copy link

lanox commented Nov 16, 2022

Assuming I understood correctly, @lanox This plugin relies on nerd fonts for it's icons, if they don't provide an icon we can't add it. You can request it on their github but it's likely in their roadmap.

I think you might be right, looking at the nerdfonts there is nothing for terraform. I might ask the question and see how it goes.

@oeuftete
Copy link

@lanox It might save you some time, I've been watching for proper terraform icon support for a while. It's been added to devicons, but it ultimately needs nerd-fonts to pull it in from that supported fork. See:

@lpuljic
Copy link

lpuljic commented Mar 8, 2023

I think terraform icon is now in nerd-fonts

@alex-courtis
Copy link
Member

I've had the terraform icon in nerd fonts hack since ~2023 01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants