Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: is there an option can be used to exclude iojs? #3386

Closed
zhaojjiang opened this issue Jul 7, 2024 · 7 comments
Closed

Comments

@zhaojjiang
Copy link

In my environment, nvm ls-remote and nvm install sometimes takes long time to connect. I am not sure why this happen (may be network).
I changed NVM_NODEJS_ORG_MIRROR with https://npmmirror.com/mirrors/node/ and it works fine with --lts option (I am not sure if this option applied to filter node?).

The confused thing is that I cannot found an available iojs mirror to speed up NVM_IOJS_ORG_MIRROR.
Is there is an option to exclude iojs? If not, will this be added?

@zhaojjiang zhaojjiang changed the title [Feature Request]: is there is an option can be used to exclude iojs? [Feature Request]: is there an option can be used to exclude iojs? Jul 7, 2024
@ljharb
Copy link
Member

ljharb commented Jul 8, 2024

This is a bit of a duplicate of #1080.

tldr, no, there isn't currently an option for that. however, it's very reasonable to allow it to be set to an empty string, and thus bypass the check.

@ljharb ljharb closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
@zhaojjiang
Copy link
Author

it's very reasonable to allow it to be set to an empty string, and thus bypass the check.

it meens empty string is not allowed for now, right? i tried empty string, it seems like empty string not work

@ljharb
Copy link
Member

ljharb commented Jul 8, 2024

Correct, it's not allowed for now. I'll add it soon tho.

@zhaojjiang
Copy link
Author

zhaojjiang commented Aug 17, 2024

@ljharb Looking forward to this.

I tried nvm install --lts 18 and it can speed up, but I don't know why, I don't know what is the difference between mirrors handler with option --lts or not, so I can't apply this option to our deploy script, I only use it manually.

Additionally, a valid mirror hub with invalid NVM_IOJS_ORG_MIRROR can get empty iojs versions, which can also be used to exclude iojs.

@ljharb
Copy link
Member

ljharb commented Aug 18, 2024

If you set the iojs mirror env var to an empty string, it should skip that lookup.

@zhaojjiang
Copy link
Author

I fetched tag v0.40.0, and tried NVM_IOJS_ORG_MIRROR with empty string, it not work, nvm ls-remote still include iojs

@ljharb
Copy link
Member

ljharb commented Aug 19, 2024

ah, you're right, that commit isn't merged yet - i still have tests to write.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants