Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and update Dockerfile #1861

Merged
merged 6 commits into from
Jul 11, 2018
Merged

Improve and update Dockerfile #1861

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e2195b4
[Dockerfile] Use LABEL instead of deprecated MAINTAINER command
PeterDaveHello Jul 8, 2018
265ec90
[Dockerfile] Add missing name & version LABEL
PeterDaveHello Jul 8, 2018
af8038f
[Dockerfile] Update ShellCheck version to v0.5.0
PeterDaveHello Jul 8, 2018
f121e5a
[Dockerfile] Add missing quotes for variables
PeterDaveHello Jul 8, 2018
aacb0b9
[Dockerfile] Fix command `From` to be `FROM`
PeterDaveHello Jul 8, 2018
04b35b5
[Dockerfile] Use arguments JSON notation for ENTRYPOINT
PeterDaveHello Jul 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,16 @@

# Use Ubuntu Trusty Tahr as base image as we're using on Travis CI
# I also tested with Ubuntu 16.04, should be good with it!
From ubuntu:14.04
MAINTAINER Peter Dave Hello <hsu@peterdavehello.org>
FROM ubuntu:14.04
LABEL maintainer="Peter Dave Hello <hsu@peterdavehello.org>"
LABEL name="nvm-dev-env"
LABEL version="latest"

# Prevent dialog during apt install
ENV DEBIAN_FRONTEND noninteractive

# ShellCheck version
ENV SHELLCHECK_VERSION=0.4.7
ENV SHELLCHECK_VERSION=0.5.0

# Pick a Ubuntu apt mirror site for better speed
# ref: https://launchpad.net/ubuntu/+archivemirrors
Expand Down Expand Up @@ -91,10 +93,10 @@ USER nvm

# nvm
COPY . /home/nvm/.nvm/
RUN sudo chown nvm:nvm -R $HOME/.nvm
RUN echo 'export NVM_DIR="$HOME/.nvm"' >> $HOME/.bashrc
RUN echo '[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" # This loads nvm' >> $HOME/.bashrc
RUN echo '[ -s "$NVM_DIR/bash_completion" ] && . "$NVM_DIR/bash_completion" # This loads nvm bash_completion' >> $HOME/.bashrc
RUN sudo chown nvm:nvm -R "$HOME/.nvm"
RUN echo 'export NVM_DIR="$HOME/.nvm"' >> "$HOME/.bashrc"
RUN echo '[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" # This loads nvm' >> "$HOME/.bashrc"
RUN echo '[ -s "$NVM_DIR/bash_completion" ] && . "$NVM_DIR/bash_completion" # This loads nvm bash_completion' >> "$HOME/.bashrc"

# nodejs and tools
RUN bash -c 'source $HOME/.nvm/nvm.sh && \
Expand All @@ -105,4 +107,4 @@ RUN bash -c 'source $HOME/.nvm/nvm.sh && \
# Set WORKDIR to nvm directory
WORKDIR /home/nvm/.nvm

ENTRYPOINT /bin/bash
ENTRYPOINT ["/bin/bash"]