Improve Dockerfile #1863
Merged
Improve Dockerfile #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Jul 12, 2018
.travis.yml
Outdated
| - '[ -z "$WITHOUT_CURL" ] || sudo apt-get remove curl -y' | ||
| script: | ||
| - if [ -n "${MAKE_RELEASE-}" ]; then export GIT_EDITOR="sed -i '1 s/^/99.99.99 make release test/'" && git fetch --unshallow --tags && echo proceed | make TAG=99.99.99 release ; fi | ||
| - if [ -n "${DOCTOCCHECK-}" ]; then cp README.md README.md.orig && npm run doctoc && diff -q README.md README.md.orig ; fi | ||
| - if [ -n "${ECLINT-}" ]; then npm run eclint ; fi | ||
| - if [ -n "${DOCKERFILE_LINT-}" ]; then npx dockerfile_lint ; fi |
There was a problem hiding this comment.
npx should not be used in scripts; if we want to depend on something, it should be a dependency. since this is a dependency, we should set up an npm run-script.
There was a problem hiding this comment.
Okay, updated.
`sudo` may lead to unpredictable behavior in some cases, and we don't really need to use `sudo` to reach what we need.
PeterDaveHello
force-pushed
the
ImproveDockerfile
branch
from
3c89157 to
4bd99bc
Compare
|
No more, as test integrated now. |
|
@ljharb anything else I need to do here? Thanks. |
ljharb
approved these changes
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.