Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary if block from nvm get artifact compression #3281

Closed
wants to merge 1 commit into from
+0 −2
Closed

remove unnecessary if block from nvm get artifact compression #3281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions nvm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2239,8 +2239,6 @@ nvm_get_artifact_compression() {
COMPRESSION='tar.gz'
if [ "_${NVM_OS}" = '_win' ]; then
COMPRESSION='zip'
elif nvm_supports_xz "${VERSION}"; then
COMPRESSION='tar.xz'
Comment on lines -2242 to -2243
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it defaults to tar dot G z, and these lines set it to tar dot X z.

It's an entirely different format, and is quite intentional so the smaller xz format can be downloaded instead.

fi

nvm_echo "${COMPRESSION}"
Expand Down
Loading