Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] nvm exec: Do a version check on nvm-exec #3308

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[Fix] nvm exec: Do a version check on nvm-exec #3308

wants to merge 7 commits into from

Commits on Mar 6, 2024

  1. fix: Do a version check on nvm-exec 

    This check would display a message in case the `.nvmrc` version is not installed, and would not alter the output otherwise.
    @userwiths
    userwiths committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    e2ff1e7 View commit details
    Browse the repository at this point in the history

  2. [Fix] nvm exec: Do a version check on nvm-exec 

    This check would display a message in case the `.nvmrc` version is not installed, and would not alter the output otherwise.
    @userwiths @ljharb
    userwiths authored and ljharb committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    05feeaa View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. tests: Add test to check if the message contains the relevant informa… 

    …tion.
    @userwiths
    userwiths committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    5a28180 View commit details
    Browse the repository at this point in the history

  2. Seems changes done in docker do not persist, had to reapply them

    @userwiths
    userwiths committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    650b069 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Merge branch 'fork-dev' of https://github.com/userwiths/nvm into fork… 

    …-dev
    @userwiths
    userwiths committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    ce777fa View commit details
    Browse the repository at this point in the history

  2. Rookie mistake from my side, forgot to clean-up the nvmrc, which caus… 

    …ed other tests to fail.

Updated version color printing test because it did not pass.
    @userwiths
    userwiths committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    59b40b8 View commit details
    Browse the repository at this point in the history

  3. remove test from slow folder

    @userwiths
    userwiths committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    8066dc8 View commit details
    Browse the repository at this point in the history