Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

converted tree path to canonical form for case-insensitive comparison, attempt to solve issue #1049 #3348

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

converted tree path to canonical form for case-insensitive comparison, attempt to solve issue #1049 #3348

wants to merge 1 commit into from

Conversation

jahir-raihan
Copy link

@jahir-raihan jahir-raihan commented May 9, 2024 •
edited by ljharb
Loading

Don't know what I tried to solve, but its getting wrose :).

Fixes #1049.

@ljharb ljharb marked this pull request as draft May 11, 2024 06:06
ljharb
ljharb requested changes May 11, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need tests.

Also, we won't want to compare case-insensitively on a case-sensitive system.

@jahir-raihan
Copy link
Author

This will need tests.

Also, we won't want to compare case-insensitively on a case-sensitive system.

Ok

@ljharb ljharb force-pushed the master branch 2 times, most recently from c6cfc3a to c20db2a Compare June 10, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nvm_tree_contains_path doesn't work on case-insensitive filesystems
2 participants
@jahir-raihan @ljharb