Skip to content

Commit

Permalink
chore: rename 'slowdown' to 'decelerate'
Browse files Browse the repository at this point in the history
  • Loading branch information
nvsukhanov committed Apr 7, 2024
1 parent 5a05907 commit 90c5aa9
Show file tree
Hide file tree
Showing 11 changed files with 33 additions and 33 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
>
<lib-cs-binding-control-select-controller [data]="forwardsControlBindingComponentData"></lib-cs-binding-control-select-controller>
<lib-cs-binding-control-select-controller [data]="backwardsControlBindingComponentData"></lib-cs-binding-control-select-controller>
<lib-cs-binding-control-select-controller [data]="slowdownControlBindingComponentData"></lib-cs-binding-control-select-controller>
<lib-cs-binding-control-select-controller [data]="decelerateControlBindingComponentData"></lib-cs-binding-control-select-controller>

<mat-error [libValidationMessages]="form.controls.inputs"
[immediatelyShowMessages]="true"
Expand Down Expand Up @@ -49,9 +49,9 @@
></lib-cs-binding-control-speed-input>
}

@if (isSlowDownControlAssigned) {
<lib-cs-binding-control-speed-input [control]="form.controls.slowdownSpeedDecrement"
[translocoTitle]="'controlScheme.accelerateBinding.slowdownSpeedDecrement'"
@if (isDecelerateControlAssigned) {
<lib-cs-binding-control-speed-input [control]="form.controls.decelerateSpeedDecrement"
[translocoTitle]="'controlScheme.accelerateBinding.decelerateSpeedDecrement'"
></lib-cs-binding-control-speed-input>
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export class AccelerateBindingEditComponent implements IBindingsDetailsEditCompo

private _backwardsControlBindingComponentData: BindingControlSelectControllerComponentData<ControlSchemeBindingType.Speed> | null = null;

private _slowdownControlBindingComponentData: BindingControlSelectControllerComponentData<ControlSchemeBindingType.Speed> | null = null;
private _decelerateControlBindingComponentData: BindingControlSelectControllerComponentData<ControlSchemeBindingType.Speed> | null = null;

constructor(
private readonly cd: ChangeDetectorRef,
Expand All @@ -72,8 +72,8 @@ export class AccelerateBindingEditComponent implements IBindingsDetailsEditCompo
return this._backwardsControlBindingComponentData;
}

public get slowdownControlBindingComponentData(): BindingControlSelectControllerComponentData<ControlSchemeBindingType.Speed> | null {
return this._slowdownControlBindingComponentData;
public get decelerateControlBindingComponentData(): BindingControlSelectControllerComponentData<ControlSchemeBindingType.Speed> | null {
return this._decelerateControlBindingComponentData;
}

public get isForwardsControlAssigned(): boolean {
Expand All @@ -84,7 +84,7 @@ export class AccelerateBindingEditComponent implements IBindingsDetailsEditCompo
return !!this.form?.controls.inputs.controls[SpeedBindingInputAction.Backwards].controls.controllerId.value;
}

public get isSlowDownControlAssigned(): boolean {
public get isDecelerateControlAssigned(): boolean {
return !!this.form?.controls.inputs.controls[SpeedBindingInputAction.Brake].controls.controllerId.value;
}

Expand All @@ -93,7 +93,7 @@ export class AccelerateBindingEditComponent implements IBindingsDetailsEditCompo
): void {
const forwardsControls = outputBinding.controls.inputs.controls[SpeedBindingInputAction.Forwards].controls;
const backwardsControls = outputBinding.controls.inputs.controls[SpeedBindingInputAction.Backwards].controls;
const slowdownControls = outputBinding.controls.inputs.controls[SpeedBindingInputAction.Brake].controls;
const decelerateControls = outputBinding.controls.inputs.controls[SpeedBindingInputAction.Brake].controls;
if (outputBinding !== this.form) {
this.form = outputBinding;

Expand All @@ -111,11 +111,11 @@ export class AccelerateBindingEditComponent implements IBindingsDetailsEditCompo
inputName$: this.l10nService.getBindingInputName(AccelerateBindingInputAction.Backwards),
supportedInputPipes: [ InputPipeType.Pulse ]
};
this._slowdownControlBindingComponentData = {
this._decelerateControlBindingComponentData = {
bindingType: ControlSchemeBindingType.Speed,
inputFormGroup: outputBinding.controls.inputs.controls[AccelerateBindingInputAction.Slowdown],
inputFormGroup: outputBinding.controls.inputs.controls[AccelerateBindingInputAction.Decelerate],
inputAction: SpeedBindingInputAction.Brake,
inputName$: this.l10nService.getBindingInputName(AccelerateBindingInputAction.Slowdown),
inputName$: this.l10nService.getBindingInputName(AccelerateBindingInputAction.Decelerate),
supportedInputPipes: [ InputPipeType.Pulse ]
};

Expand All @@ -126,9 +126,9 @@ export class AccelerateBindingEditComponent implements IBindingsDetailsEditCompo
backwardsControls.controllerId.valueChanges,
backwardsControls.inputId.valueChanges,
backwardsControls.inputType.valueChanges,
slowdownControls.controllerId.valueChanges,
slowdownControls.inputId.valueChanges,
slowdownControls.inputType.valueChanges
decelerateControls.controllerId.valueChanges,
decelerateControls.inputId.valueChanges,
decelerateControls.inputType.valueChanges
).subscribe(() => {
this.cd.markForCheck();
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export class AccelerateBindingFormBuilderService implements IBindingFormBuilder<
this.appConfig.acceleration.defaultAccelerationStep,
this.minSpeedIncrement
),
slowdownSpeedDecrement: this.commonFormControlBuilder.speedControl(
decelerateSpeedDecrement: this.commonFormControlBuilder.speedControl(
this.appConfig.acceleration.defaultAccelerationStep,
this.minSpeedIncrement
),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class AccelerateBindingFormMapperService implements IBindingFormMapper<Ac
inputs: {},
forwardsSpeedIncrement: form.controls.forwardsSpeedIncrement.getRawValue(),
backwardsSpeedIncrement: form.controls.backwardsSpeedIncrement.getRawValue(),
slowdownSpeedDecrement: form.controls.slowdownSpeedDecrement.getRawValue(),
decelerateSpeedDecrement: form.controls.decelerateSpeedDecrement.getRawValue(),
hubId,
portId,
maxSpeed: form.controls.maxSpeed.getRawValue(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export type AccelerateBindingForm = FormGroup<{
}>;
forwardsSpeedIncrement: FormControl<number>;
backwardsSpeedIncrement: FormControl<number>;
slowdownSpeedDecrement: FormControl<number>;
decelerateSpeedDecrement: FormControl<number>;
hubId: FormControl<string | null>;
portId: FormControl<number | null>;
maxSpeed: FormControl<number>;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export class AccelerateBindingInputExtractorService implements ITasksInputExtrac
binding,
globalInput$,
controllersSettings$,
binding.inputs[AccelerateBindingInputAction.Slowdown]
binding.inputs[AccelerateBindingInputAction.Decelerate]
).pipe(
distinctUntilIsActivatedChanged()
);
Expand All @@ -54,7 +54,7 @@ export class AccelerateBindingInputExtractorService implements ITasksInputExtrac
map(([forwards, backwards, brake]) => ({
[AccelerateBindingInputAction.Forwards]: forwards,
[AccelerateBindingInputAction.Backwards]: backwards,
[AccelerateBindingInputAction.Slowdown]: brake
[AccelerateBindingInputAction.Decelerate]: brake
}))
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ export class AccelerateBindingL10nService implements IBindingL10n<ControlSchemeB
return this.translocoService.selectTranslate('controlScheme.accelerateBinding.forwardsInput');
case AccelerateBindingInputAction.Backwards:
return this.translocoService.selectTranslate('controlScheme.accelerateBinding.backwardsInput');
case AccelerateBindingInputAction.Slowdown:
return this.translocoService.selectTranslate('controlScheme.accelerateBinding.slowdownInput');
case AccelerateBindingInputAction.Decelerate:
return this.translocoService.selectTranslate('controlScheme.accelerateBinding.decelerateInput');
}
}

Expand All @@ -37,7 +37,7 @@ export class AccelerateBindingL10nService implements IBindingL10n<ControlSchemeB
switch (actionType) {
case AccelerateBindingInputAction.Forwards:
case AccelerateBindingInputAction.Backwards:
case AccelerateBindingInputAction.Slowdown:
case AccelerateBindingInputAction.Decelerate:
return this.controllerInputNameService.getFullControllerInputNameData(inputConfig);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export class AccelerateBindingTaskPayloadBuilderService implements ITaskPayloadB
): { payload: SpeedTaskPayload; inputTimestamp: number } | null {
const forwardsInput = this.getActiveInput(binding, currentInput, previousInput, AccelerateBindingInputAction.Forwards);
const backwardsInput = this.getActiveInput(binding, currentInput, previousInput, AccelerateBindingInputAction.Backwards);
const brakeInput = this.getActiveInput(binding, currentInput, previousInput, AccelerateBindingInputAction.Slowdown);
const brakeInput = this.getActiveInput(binding, currentInput, previousInput, AccelerateBindingInputAction.Decelerate);

const previousSpeed = previousTask?.payload.type === TaskType.Speed ? previousTask.payload.speed : 0;

Expand All @@ -52,7 +52,7 @@ export class AccelerateBindingTaskPayloadBuilderService implements ITaskPayloadB
if (brakeInput.isActivated) {
const previousBrakeFactor = previousTask?.payload.type === TaskType.Speed ? previousTask.payload.brakeFactor : 0;

if ((Math.abs(previousSpeed) - previousBrakeFactor) <= binding.slowdownSpeedDecrement) {
if ((Math.abs(previousSpeed) - previousBrakeFactor) <= binding.decelerateSpeedDecrement) {
const payload = {
type: TaskType.Speed,
speed: 0,
Expand All @@ -65,7 +65,7 @@ export class AccelerateBindingTaskPayloadBuilderService implements ITaskPayloadB
return { payload, inputTimestamp: brakeInput.timestamp };
}
if (previousSpeed !== 0 && previousBrakeFactor !== previousSpeed) {
const nextSpeed = previousSpeed - Math.sign(previousSpeed) * binding.slowdownSpeedDecrement;
const nextSpeed = previousSpeed - Math.sign(previousSpeed) * binding.decelerateSpeedDecrement;

return {
payload: this.buildTaskPayload(nextSpeed, binding, previousTask),
Expand Down
6 changes: 3 additions & 3 deletions modules/store/src/lib/models/control-scheme.model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ export type ControlSchemeGearboxBinding = {
export enum AccelerateBindingInputAction {
Forwards = '0',
Backwards = '1',
Slowdown = '2'
Decelerate = '2'
}

export type ControlSchemeAccelerateBinding = {
Expand All @@ -205,11 +205,11 @@ export type ControlSchemeAccelerateBinding = {
inputs: {
[AccelerateBindingInputAction.Forwards]?: ControlSchemeInputConfig;
[AccelerateBindingInputAction.Backwards]?: ControlSchemeInputConfig;
[AccelerateBindingInputAction.Slowdown]?: ControlSchemeInputConfig;
[AccelerateBindingInputAction.Decelerate]?: ControlSchemeInputConfig;
};
forwardsSpeedIncrement: number;
backwardsSpeedIncrement: number;
slowdownSpeedDecrement: number;
decelerateSpeedDecrement: number;
hubId: string;
portId: number;
maxSpeed: number;
Expand Down
4 changes: 2 additions & 2 deletions src/assets/i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -361,12 +361,12 @@
"operationMode": "Accelerate",
"forwardsInput": "Forwards",
"backwardsInput": "Backwards",
"slowdownInput": "Slowdown",
"decelerateInput": "Decelerate",
"missingInputs": "At least one of the inputs must be assigned",
"outputSpeed": "Max speed",
"forwardsSpeedIncrement": "Forwards speed increment",
"backwardsSpeedIncrement": "Backwards speed increment",
"slowdownSpeedDecrement": "Slowdown increment"
"decelerateSpeedDecrement": "Deceleration increment"
},
"widgets": {
"reorderWidgetsButtonTitle": "Reorder widgets",
Expand Down
4 changes: 2 additions & 2 deletions src/assets/i18n/ru.json
Original file line number Diff line number Diff line change
Expand Up @@ -361,12 +361,12 @@
"operationMode": "Ускорение",
"forwardsInput": "Вперед",
"backwardsInput": "Назад",
"slowdownInput": "Замедление",
"decelerateInput": "Замедление",
"missingInputs": "Нужно назначить хотя-бы один контроллер",
"outputSpeed": "Макс. скорость",
"forwardsSpeedIncrement": "Шаг ускорения вперед",
"backwardsSpeedIncrement": "Шаг ускорения назад",
"slowdownSpeedDecrement": "Шаг замедления"
"decelerateSpeedDecrement": "Шаг замедления"
},
"widgets": {
"reorderWidgetsButtonTitle": "Изменить порядок виджетов",
Expand Down

0 comments on commit 90c5aa9

Please sign in to comment.