Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up additional files generated by foreground-child watchdog #1

Conversation

frattaro
Copy link

@frattaro frattaro commented Aug 7, 2024

This PR cleans up the additional files created due to foreground-child 3.x's watchdog process when nyc runs.

It also reverts changes to the (skipped + commented) tests, so it should run all the tests as they are in nyc's main no problem

Copy link
Owner

@nwalters512 nwalters512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable, thanks! We'll see what they say in the other PR 🙂

@nwalters512 nwalters512 merged commit e4e4613 into nwalters512:upgrade-foreground-child Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants