Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Notification about low battery. #180

Closed
kuba3351 opened this issue Feb 14, 2023 · 3 comments · Fixed by #181
Closed

[Feature request] Notification about low battery. #180

kuba3351 opened this issue Feb 14, 2023 · 3 comments · Fixed by #181
Labels
enhancement New feature or request

Comments

@kuba3351
Copy link

Hello

I am using nwg-shell in my everyday work on Fedora because it is very nice, but lack a very important feature.

If I disconnect my laptop from a power source, the battery goes down, and laptop is turning off instantly without any warning. Nwg-shell is trying to provide a DE-like experience, and every DE warns about low battery before the device power off.

I think nwg-shell should have this feature.

@kuba3351 kuba3351 changed the title [Feature request] Notification aboiut low battery. [Feature request] Notification about low battery. Feb 14, 2023
@nwg-piotr nwg-piotr added the enhancement New feature or request label Feb 14, 2023
@nwg-piotr
Copy link
Owner

You're right. I used to have an executor for this long time ago, but I was too lazy to implement it in the panel (my current laptop works always connected to the charger). I'll add it in the nearest future.

@kuba3351
Copy link
Author

Thank you.

The executor is ok for me if it will be inside default config files provided by nwg-shell.

@nwg-piotr
Copy link
Owner

The executor is ok for me if it will be inside default config files provided by nwg-shell.

Of course not. I'll just add it to the existing battery level code (in Controls).

@nwg-piotr nwg-piotr transferred this issue from nwg-piotr/nwg-shell Feb 14, 2023
nwg-piotr added a commit that referenced this issue Feb 19, 2023
nwg-piotr added a commit that referenced this issue Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants