Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process Event: 'uncaughtException' not working in 0.13 #4679

Closed
igfraga opened this issue Apr 5, 2016 · 1 comment
Closed

process Event: 'uncaughtException' not working in 0.13 #4679

igfraga opened this issue Apr 5, 2016 · 1 comment
Assignees
Milestone

Comments

@igfraga
Copy link

igfraga commented Apr 5, 2016

window.addEventListener('load', function(){

    process.on('uncaughtException', function(error) {
        // NEVER HAPPENS in 0.13
        process.stdout.write("CAUGHT\n"); 
        process.exit(1);
    });

    global.setImmediate(function(){
        throw("from node");
    });
});

Works as expected in 0.12.

This is crucial so that we can log errors before exiting.

Only tried it on Ubuntu.

@rogerwang rogerwang added this to the 0.13.x milestone Apr 5, 2016
@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

wanghongjuan added a commit to wanghongjuan/nw.js that referenced this issue May 21, 2018
- Add test for issue nwjs#4679
- This test is failed on v0.13.0, passed on v0.30.4
@wanghongjuan wanghongjuan self-assigned this May 21, 2018
wanghongjuan added a commit to wanghongjuan/nw.js that referenced this issue May 21, 2018
- Add test for issue nwjs#4679
- This test is failed on v0.13.0, passed on v0.30.4
rogerwang pushed a commit that referenced this issue Jun 5, 2018
- Add test for issue #4679
- This test is failed on v0.13.0, passed on v0.30.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants