Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALT+ENTER causes NW.js to crash when using --in-process-gpu #4741

Closed
geoffb opened this issue Apr 18, 2016 · 1 comment
Closed

ALT+ENTER causes NW.js to crash when using --in-process-gpu #4741

geoffb opened this issue Apr 18, 2016 · 1 comment
Assignees
@rogerwang
Milestone
0.14.x

Comments

@geoffb
Copy link

geoffb commented Apr 18, 2016 •
edited
Loading

NW.js 0.13.3, Windows 10 64-bit

Using the --in-process-gpu Chromium arg causes NW.js to crash if the user presses ALT+ENTER.

Easily reproducible with a very simple index.html and adding the following to package.json:

"chromium-args": "--in-process-gpu"

Without the using the Chromium arg, NW.js doesn't even appear to respond to the ALT+ENTER shortcut.
@rogerwang rogerwang added this to the 0.14.x milestone Apr 19, 2016
@rogerwang rogerwang assigned rogerwang and ghostoy and unassigned rogerwang Apr 19, 2016
@rogerwang
Copy link
Member

Currently upstream Chrome browser doesn't support '--in-process-gpu'. And switching to fullscreen by pressing alt-enter is done by Direct3D. It conflicts with the 'in-process-gpu' code path in Chrome somehow.

We'll see to disable Alt-Enter with '--in-process-gpu' to prevent the crash at least.

@rogerwang rogerwang assigned rogerwang and unassigned ghostoy Apr 20, 2016
ghostoy pushed a commit to ghostoy/nw.js that referenced this issue Apr 28, 2016
Patched angle to disable ALT-ENTER hotkey
118678a 
Patched angle to call `IDXGIFactory::MakeWindowAssociation` after
creating swap chain to disable ALT-ENTER hotkey.

fixed nwjs#4741
@ghostoy ghostoy mentioned this issue Apr 28, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogerwang rogerwang

Labels
None yet
Projects
None yet
Milestone
0.14.x
Development

No branches or pull requests
3 participants
@geoffb @rogerwang @ghostoy