Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

menubar background nw 0.14.5 #4851

Open
herudi opened this issue May 15, 2016 · 12 comments
Open

menubar background nw 0.14.5 #4851

herudi opened this issue May 15, 2016 · 12 comments
Assignees
Milestone

Comments

@herudi
Copy link

herudi commented May 15, 2016

imposible menubar background like electron...

@rogerwang rogerwang added this to the 0.14.x milestone May 16, 2016
@ghostoy
Copy link
Member

ghostoy commented May 16, 2016

@herudi What do you mean by "menubar background"?

@herudi
Copy link
Author

herudi commented May 17, 2016

thanks for advanced, here please look it this.
nw js menubar

how to change background color like here ?
electron menubar

@ghostoy
Copy link
Member

ghostoy commented Jun 15, 2016

@herudi I will fix it by using the standard colors for menubars on Windows and Linux. Do you believe it's necessary to change the color by code?

ghostoy pushed a commit to ghostoy/chromium.src that referenced this issue Jun 27, 2016
Menubar background should be consistent with the theme by the
system. On Windows, we use `COLOR_MENU` for the background color
for menubar.

fixed nwjs/nw.js#4851
ghostoy pushed a commit to ghostoy/chromium.src that referenced this issue Jun 29, 2016
Menubar background should be consistent with the theme by the
system. On Windows, we use `COLOR_MENU` for the background color
for menubar.

fixed nwjs/nw.js#4851
@thisKai
Copy link

thisKai commented Aug 2, 2016

I would appreciate a Javascript or CSS api for changing the colours of the menus and menubar if it is at all possible, mostly because I find the light menubar very distracting on apps with a dark theme

@ghostoy
Copy link
Member

ghostoy commented Aug 3, 2016

The menubar and popup menus will use system theme color. So if you have
dark theme, the menubar will be dark, too.

thisKai notifications@github.com于2016年8月3日周三 04:15写道:

I would appreciate a Javascript or CSS api for changing the colours of the
menus and menubar if it is at all possible, mostly because I find the light
menubar very distracting on apps with a dark theme


You are receiving this because you were assigned.

Reply to this email directly, view it on GitHub
#4851 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAczeGHTx2baav8OkoWfGjLlcC18tkAVks5qb6VpgaJpZM4IeyK_
.

@ghostoy
Copy link
Member

ghostoy commented Aug 3, 2016

@thisKai FYI. It has not been merged to the LTS version. You can test with latest stable 0.16.0 to see the menubar / context menu color. When you changed the theme, the menubar / context menu color will change as well.

@ghostoy ghostoy added the bug label Nov 18, 2016
@blaremc
Copy link

blaremc commented Jan 18, 2017

It's really need for dark applications.

@ghostoy
Copy link
Member

ghostoy commented Jan 19, 2017

@blaremc It was fixed since 0.16. You can try with latest NW.js builds. BTW, LTS targeted for legacy OSes, like Windows XP/Vista and Mac OS X 10.6 or earlier. So it's not recommended to use it for modern apps.

@blaremc
Copy link

blaremc commented Jan 19, 2017

@ghostoy was fixed what? I couldn't find anything about changing menu background or menu color in documentation :(

@ghostoy
Copy link
Member

ghostoy commented Jan 19, 2017

@blaremc The fix was using the default theme color, not a user specified color.

The menubar and popup menus will use system theme color. So if you have
dark theme, the menubar will be dark, too.

@pd-l2ork
Copy link

This is still broken on 0.42.3 because the menubar on Ubuntu 20.04 and 22.04 with a dark theme takes on white background and keeps text white, which makes it impossible to read. 0.28.3 does not have this problem, so this is a regression. Not sure about the latest version (0.69.1). That one (for my needs) has other issues that prevent me from using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants
@rogerwang @ghostoy @pd-l2ork @blaremc @thisKai @herudi @Christywl and others