-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
menubar background nw 0.14.5 #4851
Comments
@herudi What do you mean by "menubar background"? |
@herudi I will fix it by using the standard colors for menubars on Windows and Linux. Do you believe it's necessary to change the color by code? |
Menubar background should be consistent with the theme by the system. On Windows, we use `COLOR_MENU` for the background color for menubar. fixed nwjs/nw.js#4851
Menubar background should be consistent with the theme by the system. On Windows, we use `COLOR_MENU` for the background color for menubar. fixed nwjs/nw.js#4851
I would appreciate a Javascript or CSS api for changing the colours of the menus and menubar if it is at all possible, mostly because I find the light menubar very distracting on apps with a dark theme |
The menubar and popup menus will use system theme color. So if you have thisKai notifications@github.com于2016年8月3日周三 04:15写道:
|
@thisKai FYI. It has not been merged to the LTS version. You can test with latest stable 0.16.0 to see the menubar / context menu color. When you changed the theme, the menubar / context menu color will change as well. |
It's really need for dark applications. |
@blaremc It was fixed since 0.16. You can try with latest NW.js builds. BTW, LTS targeted for legacy OSes, like Windows XP/Vista and Mac OS X 10.6 or earlier. So it's not recommended to use it for modern apps. |
@ghostoy was fixed what? I couldn't find anything about changing menu background or menu color in documentation :( |
@blaremc The fix was using the default theme color, not a user specified color.
|
This is still broken on 0.42.3 because the menubar on Ubuntu 20.04 and 22.04 with a dark theme takes on white background and keeps text white, which makes it impossible to read. 0.28.3 does not have this problem, so this is a regression. Not sure about the latest version (0.69.1). That one (for my needs) has other issues that prevent me from using it. |
imposible menubar background like electron...
The text was updated successfully, but these errors were encountered: