Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.17.0-beta2 is crashing on OS X #5229

Closed
oaleynik opened this issue Aug 21, 2016 · 9 comments
Closed

0.17.0-beta2 is crashing on OS X #5229

oaleynik opened this issue Aug 21, 2016 · 9 comments
Assignees
@rogerwang
Labels
test-todo

Comments

@oaleynik
Copy link
Contributor

oaleynik commented Aug 21, 2016 •
edited
Loading

Crash report
@oaleynik
Copy link
Contributor Author

#5193 may be related

@Blatman
Copy link

Blatman commented Aug 21, 2016 •
edited
Loading

Yup - I get the same error myself when I use 0.17.0b2 with a project that uses Mac menus. When I got the good 0.17.0b1 build to work OK (as in #5193) I was using another project (PHP-POST-Test) without the menus - I will try to get a pared down example shortly which may help.

EDIT: Did a quick pare down of a project and in the following code (with all succeeding code removed) -

   nativeMenuBar = new nw.Menu({

// type: 'menubar'
});
if type: 'menubar' was commented out then the project would at least start so something is not right in the menuing area ...

@rogerwang
Copy link
Member

@oaleynik Could you please send the spec of your mac system including the CPU model? We'll check whether it's due to lacking AVX support as in #5193.

@oaleynik
Copy link
Contributor Author

@rogerwang I've sent you email with the full system report.

@Blatman
Copy link

Blatman commented Aug 22, 2016

Here is a basic project which demonstrates the crash - just place 0.17b2 into folder.
If line 31 of appbasic.js is remmed out crash will not occur (type: 'menubar'). This same code line is causing the crash on a more complicated project of mine.
017CrashTest.zip

@oaleynik
Copy link
Contributor Author

@Blatman confirmed! Without custom menu 0.17.0-beta2 can start. /cc @rogerwang

@rogerwang rogerwang self-assigned this Aug 23, 2016
ghostoy pushed a commit to ghostoy/nw.js that referenced this issue Aug 23, 2016
[mac] added base_mac.mm & base_mac.h to mac build
94db20a 
These two files provided util APIs for storing & retrieving NW menu
objects within `NSMenu`. Added them for GN build to prevent crashes
when creating menubar on Mac.

* test case: test/sanity/issue5229-menubar-crash
* fixed nwjs#5229
@ghostoy ghostoy mentioned this issue Aug 23, 2016
Merged
@rogerwang
Copy link
Member

please try http://dl.nwjs.io/live-build/08-23-2016/nw17-ca8692b-15c7eff-b55ab72-6c79a25/v0.17.0-rc1/

@oaleynik
Copy link
Contributor Author

@rogerwang live build 0.17.0-rc1 works

@Blatman
Copy link

Blatman commented Aug 23, 2016

@rogerwang - live build fine, thanks

@rogerwang rogerwang mentioned this issue Sep 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogerwang rogerwang

Labels
test-todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rogerwang @oaleynik @Blatman