Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen support #55

Closed
zcbenz opened this issue Sep 18, 2012 · 23 comments
Closed

Fullscreen support #55

zcbenz opened this issue Sep 18, 2012 · 23 comments

Comments

@zcbenz
Copy link
Contributor

zcbenz commented Sep 18, 2012

Two things on fullscreen we should support:

  • Add an API to make the whole app fullscreen chromeless
  • Support the HTML5 fullscreen API
@rrichardson
Copy link

I think a more general window attributes API would be very beneficial. For instance. I need to be able to minimize/close into the system tray rather than to the task bar. To be able to modify the window attributes to adjust the window border and to indicate that shutdown is not an option would be good as well.

@respectTheCode
Copy link

@rrichardson Appjs does something like this. They add widow.frame to make a bunch of window options available.

@daanporon
Copy link

Does this also include full screen video support? Because now if you use HTML5 video within node-webkit you're unable to make it fullscreen

@zcbenz
Copy link
Contributor Author

zcbenz commented Sep 27, 2012

There three type of full screens:

  • Fullscreen the app window
  • Fullscreen HTML5 video
  • The HTML5 fullscreen API, eg fullscreen part of the page

All of them will be supported.

@jorgenskogmo
Copy link

Sweet!
Emission of an event like WasResized / DidEnterFullscreen / DidExitFullscreen would help us respond...
Cant wait to see what you come up with.

@ubaltaci
Copy link

Is there a any progress on this issue especially fullscreen html5 video ?

@jmhmd
Copy link

jmhmd commented Apr 2, 2013

I too would love to see the HTML5 API implemented. My app runs beautifully on node-webkit, but fullscreening a portion of it is a major feature that's currently only available on the web-based version. Can't wait to have this available on the desktop!

@jmhmd
Copy link

jmhmd commented Apr 2, 2013

Also, if HTML5 fullscreen API is not supported, it should at least report document.webkitFullscreenEnabled as false, so that I can accurately hide fullscreen controls when in node-webkit. Right now it reports as true, but calling element.webkitRequestFullScreen() does nothing.

@jensvdh
Copy link

jensvdh commented Apr 28, 2013

Any progress on HTML5 fullscreen support? Would love to have full screen support for my HTML5 videos.

@AlexPoint
Copy link

We're also interested in this fullscreen support. Do you have any idea of when it's gonna be implemented?
Thanks!

@micsanbr
Copy link

I would also totally love to be able to run fullscreen videos in nw. And a million thanks for the awesome work!

@schme16
Copy link

schme16 commented Aug 28, 2013

This has been open for quite a while, is there any particular hold up?

@Nek
Copy link

Nek commented Sep 11, 2013

+1

@luwes
Copy link

luwes commented Sep 15, 2013

Love to see HTML5 fullscreen API support too!

@Carlos487
Copy link

It would be awesome to have chromeless full screen support for apps. Like the kiosk mode in Chromium or the Full Screen mode by pressing F11.

@Mithgol
Copy link
Contributor

Mithgol commented Jan 9, 2014

@Carlos487
Copy link

Awesome @Mithgol I will check it out. Thanks

@Mithgol
Copy link
Contributor

Mithgol commented Jan 14, 2014

@neilmalgaonkar
Copy link

Hi guys,

I am trying to run video with html5 video tag in node-webkit version 0.9.2 with the help of video.js library.

So before playing the video , I want it to open it in full screen. but right now its playing video nicely but not going into full screen , actually I tried with "video.webkitRequestFullscreen" but nothing happened :(.

so does it mean , as of now we can not use the full screen functionality in node-webkit?
could any one confirm it? I need to update my manager accordingly. Please do the needful :).

Thanks!

@Mithgol
Copy link
Contributor

Mithgol commented Apr 12, 2014

@neilmalgaonkar You should probably try node-webkit's API instead of WebKit's.

Try this: https://github.com/rogerwang/node-webkit/wiki/Window#windowenterfullscreen

@neilmalgaonkar
Copy link

Thanks @Mithgol.
actually i tried with fullscreen option from manifest https://github.com/rogerwang/node-webkit/wiki/Manifest-format#fullscreen , but it was putting the whole app in fullscreen on my mac when it starts, but i will try with node-webkits fullscreen api. can it be use as fullscreen option we see in youtube site?

@yeco
Copy link

yeco commented Apr 15, 2014

I'm also looking for fullscreen certain elements rather than the whole app. Any workaround?

In the meantime I've solved my issue with some css and toggleFullscreen, but it doesn't seem too elegant.

@Mithgol
Copy link
Contributor

Mithgol commented Apr 15, 2014

HTML5 fullscreen API is not supported and that's why this issue is still open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests