Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nwjs crash when opening new window without menu on windows #5737

Closed
zedissime opened this issue Mar 1, 2017 · 3 comments
Closed

Nwjs crash when opening new window without menu on windows #5737

zedissime opened this issue Mar 1, 2017 · 3 comments
Assignees

Comments

@zedissime
Copy link

Hello,

The application crashes when you try to open a new window without the window menu.
I've noticed that setting win.menu = null makes the application instantly crash.
I may have misunderstood the related documentation but it was working at least on 0.20.1 (I've skipped the 0.20.2). Also, I can't reproduce the error on MacOS.
I also propose to add the http://dl.nwjs.io/ link on the Understanding Crash Dumb documentation, in order to easily find the sym files.

  • Nw : 0.20.3-sdk-win64 && 0.20.3-normal-win64
  • OS : Windows 10 x64
  • Reproduce :
    nw.Window.open('file.html', { show: false }, function (newWindow) { newWindow.menu = null; });
  • crash_dump.dmp.zip
@Christywl
Copy link
Contributor

Reproduced with the code on Windows with nwjs-sdk-0.20.3 and 0.21.0.

@sunlin-link
Copy link

@rogerwang Can I take this issue?

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants