Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NW crash on WebMIDI sysex send recurred #7007

Closed
g200kg opened this issue Mar 9, 2019 · 8 comments
Closed

NW crash on WebMIDI sysex send recurred #7007

g200kg opened this issue Mar 9, 2019 · 8 comments
Assignees

Comments

@g200kg
Copy link

g200kg commented Mar 9, 2019

NWJS Version : v0.37.0-beta1-win-x64
Operating System : windows 10 x64

in #6502 ,
I confirmed that this problem was fixed on nw29, but now this problem has recurred.
I do not know when it happened, and it may be another problem.

crash dump:
01e2678d-9378-4a0a-9680-19c6f3cb77a8.zip


In the program below, the display of "requestMIDIAccess OK" works normally. After that, sendNoteOn has no problem, but when I run sendSysEx, the NW window closes.

(You need to connect some MIDI devices to test it)

How to reproduce

<script>
let midiout=[];
alert("requestMIDIAccess start");
navigator.requestMIDIAccess({sysex:true}).then(
    function(ma){
      alert("requestMIDIAccess OK");
      let it=ma.outputs.values();
      for(let o=it.next(); !o.done; o=it.next()) {
        midiout.push(o.value);
      }
      alert("midiout found : "+midiout[0].name);
    },
    function(e){alert("requestMIDIAccess Error");},
  );
alert("requestMIDIAccess end");

function sendNoteOn(){
  midiout[0].send([0x90,0,0]);  // note On
  alert("send noteOn");
}
function sendSysEx(){
  midiout[0].send([0xf0,0x7e,0x7f,0x09,0x01,0xf7]); // GM on
  alert("send sysex message");
}
</script>

<button onclick="sendNoteOn()">Send NoteOn : send([0x90,0,0])</button>
<button onclick="sendSysEx()">Send Sysex : send([0xf0,0x7e,0x7f,0x09,0x01,0xf7])</button>
@ffanny
Copy link
Member

ffanny commented Mar 10, 2019

I can reproduce with nwjs-sdk-v0.36.4&0.36.5&0.37.0-win.
The NW window crashed when run sendSysEx().

@rogerwang
Copy link
Member

rogerwang commented Mar 10, 2019 via email

@ffanny
Copy link
Member

ffanny commented Mar 10, 2019

What is the latest working version?

On March 10, 2019 9:58:22 AM GMT+08:00, ffanny @.***> wrote: I can reproduce with nwjs-sdk-v0.36.4&0.36.5&0.37.0-win. The NW window crashed when run sendSysEx(). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #7007 (comment)
-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

The latest working version is 0.29.4-win.

@rogerwang
Copy link
Member

Thanks @ffanny . Does it work within NW2 mode in 0.36 or 0.37?

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

@ffanny
Copy link
Member

ffanny commented Mar 10, 2019

@rogerwang It works within NW2 mode in 0.36 & 0.37.

@rogerwang
Copy link
Member

CC #5875 to record another issue fixed by NW2 mode.

@g200kg
Copy link
Author

g200kg commented Mar 11, 2019

I have confirmed it is fixed at 3/11/19 nightly build.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants