-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App won't quit on Mac #7355
Comments
Thanks for reporting. But your sample works for me. |
FWIW - I tried test app on 10.13.6 (0.44.0) and it will not quit without force-quit. OK with nw2 disabled. I tested by just dropping nwjs into the src folder and double-clicking (probably why the taskbar icon showed the nwjs icon rather than the paws). My apps with windows are OK so maybe this is only an issue if there is no window. |
I think, that it's similar to #7271. |
I'm on macOS Catalina 10.15.3 This works as expected:
This one quits when clicking Quit App in tray menu, but does not quit when clicking Quit after right-click on dock icon
We observe the same with other app that has "main": "index.html" and opens a window. |
I did some more testing, it seems that all comes down to difference in how Quit action on dock icon menu and how First of all, if app does not have window then Quit on dock icon menu does not exit the app, if app has window and does not add handler for Now, if app adds handler to In In So, if logic for handling of It can be demonstrated by running something like this in dev console in vanilla sdk install and then attempting Quit via dock icon menu:
Also, not that it matters, in |
This shares similar root cause with #7298 |
This is fixed in git and will be available in the next nightly build. |
Thank you both (@rogerwang and @arudnev) so much! This is fantastic news. |
NWJS Version : 0.44.0
Operating System : Mac OS Catalina 10.15.1
Expected behavior
Quitting the app from the system menu or by right-clicking the dock icon should quit the app. Processes nwjs, nwjs Helper, nwjs Helper (GPU) and nwjs Helper (Renderer) should all disappear from the Activity Monitor and the tray icon and dock icons should disappear.
Actual behavior
The icon remains in the dock and the tray menu remains. nwjs, nwjs Helper, nwjs Helper (GPU) and nwjs Helper (Renderer) are all still active in Activity Monitor.
Calling the
nw.App.quit()
method manually does successfully close the app.Running with
--disable-features=nw2
does lead to expected behaviour.How to reproduce
nw2_quit_bug
using your terminal$ npm install
to install latest nwjs release: v0.44.0$ npm start
to start the app. A paw icon will appear in system tray.The text was updated successfully, but these errors were encountered: