Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iFrame bug starting from v0.43.5 #7448

Closed
AdrienFrance opened this issue Apr 22, 2020 · 2 comments
Closed

iFrame bug starting from v0.43.5 #7448

AdrienFrance opened this issue Apr 22, 2020 · 2 comments
Assignees

Comments

@AdrienFrance
Copy link

Hello Roger!

I recently tried to update my NWJS app (https://you.dj) but I am facing a blocking issue.

My app is embedding Youtube videos and as you know youtube videos are iframe. In the newest version of NWJS the Youtube videos won't play anymore in my app and I get a "video unavailable" error.

I have investigated and I found that the issue appeared in v0.43.5 and I also found that you changed something in your iframe implementation here : #7305, it might be related...

Here is a video of the problem I made for you : https://you.dj/nwjs-iframe-bug.mp4

nwjs-iframe-bug

The iframe code is :

<iframe width="560" height="315" src="https://www.youtube.com/embed/tspNk3SwZ9s" frameborder="0" nwdisable nwfaketop allowfullscreen></iframe>

Here is the simple test case I made to try on your side : nwjs-iframe-bug.zip

PS : my app (and my simple test case) runs a webserver and loads all the html5 code under http://127.0.0.1:8082/index.html, this is mandatory for some chrome APIs like webaudio/webmidi, maybe you never tried this scenario...

Thanks a lot for helping me and for making NWJS,

Stay healthy,

Adrien

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

@AdrienFrance
Copy link
Author

AdrienFrance commented Apr 22, 2020

Roger you are just THE BEST, thank you!!!! I will be able to update my app with the latest NWJS. Keep up this amazing work, I am using NWJS for years now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants