Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app crashed after reload/refresh using web workers #7487

Closed
f3l1x opened this issue May 21, 2020 · 7 comments
Closed

app crashed after reload/refresh using web workers #7487

f3l1x opened this issue May 21, 2020 · 7 comments

Comments

@f3l1x
Copy link

f3l1x commented May 21, 2020

NWJS Version : 0.46.0-sdk
Operating System : OSX

Expected behavior

Don't crash.

Actual behavior

Screenshot_2020-05-21_at_14_35_24

How to reproduce

  1. Open app.
  2. Register web worker.
self.onmessage = e => console.log(e);
self.postMessage('OK');  
  1. nw.Window.get().reload()
  2. Wait 5-20s.

More info

  • tested on 0.45.4 - 0.46.0 with same result
  • nw.Window.get().reloadDev() => TypeError: nw.Window.get(...).reloadDev is not a function
@f3l1x
Copy link
Author

f3l1x commented May 22, 2020

Today it just crashed using Web Worker without redirect/reload/refresh. :-/

@peq42
Copy link

peq42 commented May 22, 2020

can reproduce on windows 10, also I had reported that before aswell(in an issue reporting crashes caused by worker threads)

@rogerwang
Copy link
Member

Could you please provide a full sample (not code snippets) so we can reproduce?

@rogerwang rogerwang changed the title [0.46.0] app crashed after reload/refresh using web workers app crashed after reload/refresh using web workers May 23, 2020
@f3l1x
Copy link
Author

f3l1x commented May 24, 2020

Hey @rogerwang. Here is MVP.

https://github.com/webkitty/playground/tree/master/nwjs/bugs/7487-web-worker.

  1. npm install
  2. npm run dev
  3. Click to button until app crashed (about 3-5x times).

It's basically same issue as here #7148 (comment).

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

@f3l1x
Copy link
Author

f3l1x commented Jun 9, 2020

Confirmed! It works now. Thank you.

@xland
Copy link
Contributor

xland commented Feb 17, 2022

This issue also happens on 0.61.0.0
@rogerwang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants