Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Window.setVisibleOnAllWorkspaces API #2722

Merged
merged 1 commit into from
Dec 1, 2014
Merged

Conversation

mrfabbri
Copy link
Member

@mrfabbri mrfabbri commented Dec 1, 2014

For platforms that support multiple workspaces (currently Mac and Linux), this allows node-webkit windows to be visible on all workspaces simultaneously.

  • Add SetVisibleOnAllWorkspaces method to Window API objects.
  • Add implementation for Mac OS X.
  • Add implementation for Aura (Linux).
  • Add configuration support via boolean 'window' subfield 'visible-on-all-workspaces' in manifest file (see https://github.com/rogerwang/node-webkit/wiki/Manifest-format#window-subfields ).
  • Add Window.canSetVisibleOnAllWorkspaces() API method returning a a boolean
    indicating if the platform (currently OS X and Linux) support Window API object
    method setVisibleOnAllWorkspace().
  • Add manual test for SetVisibleOnAllWorkspaces method to the Window API object.

FIX #2523

For platforms that support multiple workspaces (currently Mac and Linux), this allows node-webkit windows to be visible on all workspaces simultaneously.

- Add `SetVisibleOnAllWorkspaces` method to `Window` API objects.
- Add implementation for Mac OS X.
- Add implementation for Aura (Linux).
- Add configuration support via boolean `'window'` subfield `'visible-on-all-workspaces'` in manifest file (see https://github.com/rogerwang/node-webkit/wiki/Manifest-format#window-subfields ).
- Add `Window.canSetVisibleOnAllWorkspaces()` API method returning a a boolean
indicating if the platform (currently OS X and Linux) support `Window` API object
method  `setVisibleOnAllWorkspace()`.
- Add manual test for `SetVisibleOnAllWorkspaces` method to the `Window` API object.

FIX nwjs#2523
rogerwang added a commit that referenced this pull request Dec 1, 2014
Add Window.setVisibleOnAllWorkspaces API
@rogerwang rogerwang merged commit 0d9a031 into nwjs:master Dec 1, 2014
@rogerwang
Copy link
Member

Could you please add document to the wiki? @mrfabbri

@tommoor
Copy link

tommoor commented Dec 16, 2014

Created an issue here: #2813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants