Fixed ConvertToAbsolutePath to return a absolute path
#5403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When starting apps from a folder of parent, such as `nw ../app_root/`, icon file cannot be loaded correctly. The root cause is that `base::ReadFileToString` refused for path referencing to parent folder. However path of icon obtained by `nw::Package::ConvertToAbsolutePath` is still a relative path. The patch fixes `ConvertToAbsolutePath` to return a absolute path. fixed nwjs#5402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting apps from a folder of parent, such as
nw ../app_root/,icon file cannot be loaded correctly. The root cause is that
base::ReadFileToStringrefused for path referencing to parentfolder. However path of icon obtained by
nw::Package::ConvertToAbsolutePathis still a relative path.
The patch fixes
ConvertToAbsolutePathto return a absolute path.fixed #5402