Skip to content

Commit

Permalink
fix Windows component build
Browse files Browse the repository at this point in the history
libplatform is forced to be built as a static library in NW.js, so
USING_V8_PLATFORM_SHARED should not be defined for its direct
dependents. Instead, the macro should be defined at the same place as
USING_V8_SHARED since libplatform is part of the main V8 library now.

Refs: nwjs/nw.js#6172
  • Loading branch information
hujiajie authored and rogerwang committed Nov 6, 2017
1 parent d8da2f0 commit 17eb644
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ config("internal_config_base") {
# This config should be applied to code using the libplatform.
config("libplatform_config") {
include_dirs = [ "include" ]
if (is_component_build) {
if (false) {
defines = [ "USING_V8_PLATFORM_SHARED" ]
}
}
Expand Down Expand Up @@ -206,6 +206,7 @@ config("external_config") {
defines = [
"V8_SHARED",
"USING_V8_SHARED",
"USING_V8_PLATFORM_SHARED",
]
} else {
defines = [
Expand Down

0 comments on commit 17eb644

Please sign in to comment.