Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

Web/fix/feature flag typo #222

Merged
merged 2 commits into from
Dec 16, 2018
Merged

Web/fix/feature flag typo #222

merged 2 commits into from
Dec 16, 2018

Conversation

chamkank
Copy link
Contributor

🎟️ Ticket(s): Closes #


👷 Changes

This fixes a feature flag typo in the volunteer application. Previously it checked that the hacker application feature flag was enabled instead of the volunteer application feature flag.

🔦 Testing Instructions

Already tested, but if you want to double check that it works just:

  1. make web
  2. Toggle the enabled field in the feature_flags/volunteer_application through the firebase console.
  3. Check that the volunteer application is enabled/disabled successfully.

Copy link
Contributor

@Ciuffi Ciuffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn. my bad. good fix!

@chamkank chamkank merged commit 8a0b1c7 into master Dec 16, 2018
@chamkank chamkank deleted the web/fix/feature-flag-typo branch December 16, 2018 23:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants