Do not error out when no credentials are provided #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tiangolo Thank you very much for your PR! I'll merge this. This PR related to |
|
Great, thank you! 🎉 |
|
@tiangolo Hi! I'd like to make an announcement for you, which might be helpful and related to this issue. I made a GitHub Actions to preview pull-request of forked repo.
Here is an actual pull request from non-maintainers: |
|
@tiangolo Hi, I made another more general GitHub Actions than the previous comment. You will get preview-branch to run GitHub Actions with
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if Netlify credentials are not provided, this action terminates with an error.
But GitHub currently doesn't provide secrets (with Netlify credentials) to GitHub actions triggered by PRs from forks. They are only provided to actions triggered by PRs from branches on the same repo.
This means that if someone sends a PR with changes from a fork, it's currently not possible to deploy a preview (it's currently just not supported by GitHub), and this action will always report an error in those cases.
The change in this PR makes the action just not run in that case, not deploying, instead of exiting with an error. And that way it lets the rest of the CI run.