Custom app names, exec paths, etc.

[adam-lynch]

Have a read through the updated readme to see how everything has changed.

The tests seem to be fine on Windows & Mac. I'm currently using this branch as my dependency in my own app (on Windows) and I haven't gotten it 100% correct (it's probably my own code, the final app isn't being opened).

@edjafarov could you test this for me please? It would be great if you could check that the unpacking of Mac & Linux packages are the same as Windows.

E.g. if you have a x.zip (stored wherever you downloaded it) then it'll get unpacked into <tmp>/x. So if there's a file a.js at the root, then it'll be at <tmp>/x/a.js.

Also it should be assumed that your app is based on manifest.name and at the root of your package, e.g. after unpackaging it would be located at <tmp>/<packageBaseName>/<manifest.name>.app, <tmp>/<packageBaseName>/<manifest.name>.exe or <tmp>/<packageBaseName>/<manifest.name> (linux), unless you manually override it.

Related: #23, #25, #35,

[adam-lynch]

Ok, great, I can confirm this works perfectly for my needs (on Windows). My problem was that I was quicking the intermediary app too quickly.

In the end, the code is:

gui.Shell.openItem execPath
setTimeout gui.App.quit, 1000

(execPath is gui.App.argv[1])

We're just using gui.Shell.openItem because it's simpler & we don't need to pass arguments to the final app.

[edjafarov]

Awesome finding! Could you also change exec to gui.Shell.openItem in the test app. I guess that would help everyone.
You rock 🤘!

[adam-lynch]

But that means replacing updater.run with it?

Thanks haha 😄

[edjafarov]

But that means replacing updater.run with it?

yeah:)

you want me to merge? Or you are not finished yet?

[adam-lynch]

Could you please test what I said (at the top of the PR)? I think it mightn't be right, but if it is, then it's ready to merge

[edjafarov]

I will test it and merge tomorrow. It's too late right now:)

[adam-lynch]

Thanks 👍

[adam-lynch]

But that means replacing updater.run with it?

yeah:)

So does this mean we should remove updater.run from the API?

[edjafarov]

I am not sure - the thing is that for linux for example extracted files lose their executable state. Maybe we will beat zip stuff eventually. Until then we need to do things before running stuff.

[adam-lynch]

I am not sure - the thing is that for linux for example extracted files lose their executable state. Maybe we will beat zip stuff eventually. Until then we need to do things before running stuff.

I don't understand sorry.

To be clear, I'm saying maybe we should just remove updater.run from the API and advocate gui.Shell.open instead. I'm not saying remove updater.runInstaller or even pRun.

If you want I could keep updater.run and just make it call gui.Shell.open underneath (but then it wouldn't accept any arguments anymore).

[edjafarov]

I don't understand sorry.

this https://github.com/edjafarov/node-webkit-updater/blob/master/app/updater.js#L281 line here.

when files are extracted they kinda text files. To make em executables that you can run you need to chmod them.

so there is stuff that is required to be done before run. So yes:

keep updater.run and just make it call gui.Shell.open underneath (but then it wouldn't accept any arguments anymore).

right now I am trying to make it work for ubuntu - for some reason it is not running so that is what I am working now.

[adam-lynch]

Ok thanks. So maybe in the end we'll still have updater.run but for Mac & Windows it'll just do gui.Shell.app.

[edjafarov]

gui.Shell.openItem is not working - it just opens stuff with current app assigned to this type

error opening location: No application is registered as handling this file

We would need to stick with exec thus I need to investigate why this stuff is dying in ubuntu.
BWT if you don't care of ubuntu - we can merge it. I will create a bug and will fix it separately.

[adam-lynch]

In my own use case, I only care about Windows because my app will be updated through the Mac app store. But I can change it to use gui.Shell.openItem for everything but Mac (only for updater.run) and then it'll still work for Ubuntu too.

[edjafarov]

it works on windows?

[adam-lynch]

Yep.

[adam-lynch]

It works on Mac too. Like I tested if gui.Shell.open opened _.apps too

[edjafarov]

Ok, since run implementations are OS dependent do it for win and mac without API change.
that would be enough.

[adam-lynch]

Ok, but I'll have to add a note that the args and options parameters aren't used for Mac & Windows.

[adam-lynch]

Ok, that's done. I've merged in those changes here (including the new checkNewVersion) into this branch. So I'm merging now.