Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix basic example, which will fail on Windows #96

Closed
wants to merge 1 commit into from
Closed

fix basic example, which will fail on Windows #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions examples/basic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
var gui = require('nw.gui');
var pkg = require('../package.json'); // Insert your app's manifest here
var updater = require('node-webkit-updater');
var path = require('path')
var upd = new updater(pkg);
var copyPath, execPath;

Expand Down Expand Up @@ -44,9 +45,9 @@ else { // if no arguments were passed to the app
// ------------- Step 3 -------------
upd.unpack(filename, function(error, newAppPath) {
if (!error) {

var newAppDir = path.dirname(newAppPath);
// ------------- Step 4 -------------
upd.runInstaller(newAppPath, [upd.getAppPath(), upd.getAppExec()],{});
upd.runInstaller(newAppPath, [upd.getAppPath(), upd.getAppExec()], {cwd: newAppDir} );
gui.App.quit();
}
}, manifest);
Expand Down