Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 📌 add replace commands to go.mod files #9

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

mhornbacher
Copy link
Contributor

This is currently an ongoing issue with go.work configurations in golang/go#50750

As discussed in nx-go/nx-go#127 we should update the demo to demonstrate an actual setup so that other engineers running across this issue can see a clear demonstration of how it needs to be fixed.

For example nx-go-playground/math needs to be replaced in both nx-go-playground/cli and nx-go-playground/geometry even though it is only depended upon in nx-go-playground/geometry as the entire chain needs to be replaced in order for go get to work properly.

Note that this is not required for go build or go run. Just for updating dependencies.

This is currently an ongoing issue with go.work configurations in golang/go#50750
@utarwyn utarwyn merged commit 86bdc59 into nx-go:main Aug 6, 2024
@utarwyn
Copy link
Member

utarwyn commented Aug 6, 2024

Sorry for the delay... Massive thank you for the contribution! 💯
Thanks also for digging into the subject and informing the community. We hope to see some action from Go in the future!

@mhornbacher
Copy link
Contributor Author

Dude, no worries at all! Thank you so very much for not only building and contributing to this but accepting feedback from the small community of nix-go users out here 🚀 🚀

You really are the man!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants