fix nodejs build on v16 #1048
fix nodejs build on v16 #1048
Conversation
|
Hmmm. I'll try to test if there is a bug in this patch by changing the path to an insanely long one. Please wait for a while. |
|
I have tested it and the existing patch builds fine even with unusually long paths, e.g., unusually long paths that cause "execvp: printf: Argument list too long". Could you please clarify what your patch is intended to do? |
|
i did not have a "execvp: printf: Argument list too long", i had a "/bin/sh: printf: Argument list too long" error in docker. |
|
i have ulimit unlimited, but it still giving this error. |
|
i experienced from yesterday: now with this latest argument too long patch is working as it is: |
|
You need to distinguish between events.
This pull request is about a long path, which is not a problem at the moment. The event related to binutils is that there are not enough file descriptors, so we need to use ulimit to increase the openfile descriptor.
You probably need to write 'ulimit -n 2048' in this script, or there may be a docker limitation, so you should check the docker limitation. |
|
it's ulimit is already unlimited. and sill giving this error. |
|
you can see the docker unlimited settings: |
You'll need "-n" as well as "-s." |
never mind... |
|
Stay calm and try to isolate the event. Where is this error that you have just submitted?
Is it possible to debug your script? If you can, try to find out which step it is coming from. |
|
it is working any way, have been working non stop for 2 days to build this and finally it works. i am done with this build. what do you debug my script? it is a simple make all... there is nothing to debug. |
You'll find out :) If a problem arises, dig deeper so that you can get to the problem. I'm a newbie to Docker. :) |
|
I am aware that this issue has already been resolved in this repository. |
|
it is building right now. and you are right. it is not the |
|
i increased to |
this is not working, i am done with this. that patch works as yesterday... |
|
SUMMARY After careful review of this pull request, it is clear that only the following points have been changed. define xargs
-$(1) $(wordlist 1,1000,$(2))
-$(if $(word 1001,$(2)),$(call xargs,$(1),$(wordlist 1001,$(words $(2)),$(2))))))
+$(1) $(word 1,$(2))
+$(if $(word 2,$(2)),$(call xargs,$(1),$(wordlist 2,$(words $(2)),$(2))))
endefThe build bug is the point that is fixed here. The build bug is fixed here, i.e., the argument is changed to one instead of 1000 units. I agree that 1000 units is too large, considering what happened. I'll close this pull request once it's done. |
No description provided.