use print_hex_dump_debug() in imx_rpmsg_tty.c #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
print_hex_dump_debug() uses print_hex_dump(KERN_DEBUG) if CONFIG_DYNAMIC_DEBUG is not set, but is uses Dynamic Debug if CONFIG_DYNAMIC_DEBUG is set. Without this change, print_hex_dump(KERN_DEBUG) is used even if CONFIG_DYNAMIC_DEBUG is set, and so the end user cannot benefit from Dynamic Debug even it's enabled. And all the messages sen to to rpmsg are logged into the journal without an easy way to disable this (the only way is to change the logging level for the whole kernel !!!!). Even when Dynamic Debu is enabled and available. See support case 00636789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
print_hex_dump_debug() uses print_hex_dump(KERN_DEBUG) if CONFIG_DYNAMIC_DEBUG is not set, but is uses Dynamic Debug if CONFIG_DYNAMIC_DEBUG is set.
Without this change, print_hex_dump(KERN_DEBUG) is used even if CONFIG_DYNAMIC_DEBUG is set, and so the end user cannot benefit from Dynamic Debug even it's enabled.
And all the messages sen to to rpmsg are logged into the journal without an easy way to disable this (the only way is to change the logging level for the whole kernel !!!!). Even when Dynamic Debu is enabled and available.
See support case 00636789