zstd-codec support for decompressing files #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nxpfrankli
reviewed
Jul 24, 2023
nxpfrankli
reviewed
Jul 24, 2023
nxpfrankli
requested changes
Jul 25, 2023
webusb/index.js
Outdated
| // require("../libwebusb/module.js").run((binding) => {window.binding = binding} ) | ||
| // require("./node_modules/zstd-codec/lib/module.js").run((binding) => {window.binding = binding} ) | ||
| // window.binding = "test"; | ||
| // window.fs = require('fs'); |
| @@ -3,26 +3,24 @@ | |||
| "version": "0.1.0", | |||
| "private": true, | |||
| "dependencies": { | |||
| "-": "^0.0.1", | |||
| "@testing-library/jest-dom": "^5.16.5", | |||
| "@testing-library/jest-dom": "^5.16.5", | ||
| "@testing-library/react": "^13.4.0", | ||
| "@testing-library/user-event": "^13.5.0", | ||
| "fs": "^0.0.1-security", | ||
| "g": "^2.0.1", |
| }, | ||
| "scripts": { | ||
| "start": "react-scripts start", | ||
| "build": "react-scripts build", | ||
| "build": "react-scripts build; browserify index.js -o build/bundle.js -t babelify --presets es2015; ", | ||
| "test": "react-scripts test", |
There was a problem hiding this comment.
supposed, need run browserify before react-script
| @@ -3,6 +3,7 @@ import ReactDOM from 'react-dom/client'; | |||
| import './index.css'; | |||
| import App from './App'; | |||
| import reportWebVitals from './reportWebVitals'; | |||
| // import * as Z from 'zstd-codec' | |||
|
|
|||
|
|
||
| const processChunk = async(data, curr_len, i) => { | ||
| console.log(data, curr_len, i); | ||
|
|
There was a problem hiding this comment.
avoid log data, it is too big
| async function send_packet(raw_data) { | ||
| await USBDevice.transferOut(1, raw_data); | ||
| console.log("transferout", raw_data); | ||
| } |
| if (!flashFile) return; | ||
|
|
||
| const file = flashFile; | ||
| let buff = await file.arrayBuffer() |
| let totalBytes = 0; | ||
|
|
||
| console.log(data) | ||
|
|
There was a problem hiding this comment.
avoid log data, which just for debug
| return null; | ||
| } | ||
|
|
||
| console.log("finishing unzipping"); |
There was a problem hiding this comment.
I am little confused here, after you decompress whole data, then trigger read. did you check memory usage here. You can stop here to check how many memory used by browser.
|
Thanks, I takes some times to merge your patches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.