Raspberry usb fix #92
Conversation
|
please fix build error |
|
I would gladely... if I had some windows build environment.... I tried to find the way you export symbols on windows (usually a EXPORT macro is used... this is not the case... ) |
|
you may missed conf.cpp in visual studio's project file. |
| if (str.size() > 2 && | ||
| str.substr(0, 2).compare("0x") == 0) | ||
| { | ||
| val = strtoul(start+2, &endPtr, 16); | ||
| ss << std::hex << str.substr(2); | ||
| } |
There was a problem hiding this comment.
what's problem do you try to fix? the function should be the same
There was a problem hiding this comment.
don't know why but the old code fail to convert on x86_64 latest ubuntu.... and well c++ conversion function are more robust than the strtoul legacy
There was a problem hiding this comment.
It pass ubuntu 18.08 at auto build system.
| string size = get_next_param(m_cmd, pos); | ||
| Conf::GetConf().m_USB.m_HIDMaxTransfer = str_to_uint(size); | ||
| cout << "changed USB::HID::MAX_PACKET_SIZE to " << Conf::GetConf().m_USB.m_HIDMaxTransfer << endl; | ||
| } |
There was a problem hiding this comment.
Avoid print at libuuu, which will block UI deplay.
Please use notification function to tell uplayer application. Show or hide this information decide by application.
| set_last_err_string(err); | ||
| return -1; | ||
|
|
||
| } |
There was a problem hiding this comment.
Dose CmdBase::insert_param_info match your parser requirement? That simplify parser work.
| @@ -289,6 +298,7 @@ CmdObjCreateMap::CmdObjCreateMap() | |||
|
|
|||
| (*this)["_ALL:DONE"] = new_cmd_obj<CmdDone>; | |||
| (*this)["_ALL:DELAY"] = new_cmd_obj<CmdDelay>; | |||
| (*this)["_ALL:CONFIG"] = new_cmd_obj<CmdConfig>; | |||
There was a problem hiding this comment.
Are you sure all protocol need config command.
There are already have CFG: protocol to set PID VID to protocol map?
which will run once at beginning.
CFG: HID -maxtimeout 1000
There was a problem hiding this comment.
what is CFG protocol? this isn't documented... I don't understand your remark....
There was a problem hiding this comment.
in help
CFG: Config protocol of specific usb device vid/pid
SDPS|SDP|FB\Fastboot|FBK -chip <chip name> -pid <pid> -vid <vid
| @@ -310,11 +314,13 @@ int FBCopy::run(CmdCtx *ctx) | |||
| nt.total = buff->size(); | |||
| call_notify(nt); | |||
|
|
|||
| for (i = 0; i < buff->size(); i += this->m_Maxsize_pre_cmd) | |||
| for (i = 0; | |||
There was a problem hiding this comment.
m_Maxsize_pre_cmd need be update at beginning, such as construct function or at parser function. so needn't change below code.
There was a problem hiding this comment.
the code is needed here because we have to know about the packet size to split the content, using construct fonction or at parser level will imply lot of modifications since there is no way to go from parser to low level constructor, doing so will require modify lot of API... I didn't wanted to go that way because it overcomplicate the process, while a configuration class singleton store the configuration in a dedicated place and is easely integrated
| sz, | ||
| &actual, | ||
| Conf::GetConf().m_USB.m_HIDTimeout | ||
| ); |
There was a problem hiding this comment.
you should update m_read_timeout.
There was a problem hiding this comment.
read time out seems to be something not tunable if I correctly remember.... only write timeout is meaningfull for tunning (remembered seeing that in libusb documentation...)
| << Conf::GetConf().m_USB.m_BulkTimeout | ||
| << " ms" | ||
| << endl; | ||
| retries_on_timeout = 3; |
There was a problem hiding this comment.
All error message should use set_last_error_string. Or notification function.
nxpfrankli
force-pushed
the
master
branch
14 times, most recently
from
4021f88 to
3f63f0b
Compare
nxpfrankli
force-pushed
the
master
branch
5 times, most recently
from
1597a12 to
0f8362f
Compare
nxpfrankli
force-pushed
the
master
branch
10 times, most recently
from
629d224 to
8925b6c
Compare
this is a bugfixes to allow to tune low level usb parameter in case of usb instabilities