New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: save modified settings to share link #36

Merged

JonasDoesThings merged 1 commit into nxt3AT:dev from JonasDoesThings:dev

Oct 22, 2022

Member

JonasDoesThings commented Oct 22, 2022 •

edited

Loading

As discussed in issue #30. Only modified settings are stored in the URL.

Current limitations:

It doesn't have any kind of 'version control' for the settings. So if we change the default settings at any point in the future, then existing URLs will also change in behavior.


          feat: save modified settings to share link

2f9b660

JonasDoesThings mentioned this pull request

feature request: save settings to share link #30

Closed

JonasDoesThings linked an issue

that may be closed by this pull request

feature request: save settings to share link #30

Closed

JonasDoesThings self-assigned this

JonasDoesThings merged commit 5e26c06 into nxt3AT:dev

JonasDoesThings mentioned this pull request

refactor: improve sharing settings via link #37

Merged

Member Author

JonasDoesThings commented Oct 22, 2022

Since I didn't know that you couldn't re-open and edit a PR after merging, I've added some fixes in PR #37.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet