Pagination support #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… gh::get_release_assets() as well as gh::get_release_assets_by_release_id()
… of 502 it was some time ago) + added a bit more logging to branches query for failure analysis
…ected property rewriting as non-premium github orgs (like tipibuild/) cannot have protected branches (anymore?)
…the paginating calls instead of copying into temporary
daminetreg
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed recently we need pagination support on a couple of GH APIs which have been added now.
APIs that have first level API pagination (like branches / issues etc) are doing the link following automatically.
Small bugfix: it turns out that the issue.body property is actually nullable (was causing crashes in the new test), so the property was changed to be an
std::optional.