Add menu option to interrupt a contact #3905
Conversation
|
Not sure about this because the interrupt action will be asynchronous... maybe for the single contact case we should have a endpoint to do it synchronously so the user sees the current flow badge disappear after they click this. |
rowanseymour
force-pushed
the
contact_interrupt
branch
from
d955d64 to
cc5ed99
Compare
Codecov Report
@@ Coverage Diff @@
## main #3905 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 394 394
Lines 26380 26397 +17
=========================================
+ Hits 26380 26397 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
I think we definitely want to start with a sync endpoint for this. |
| @@ -618,6 +619,7 @@ | |||
| "contacts.contact_export", | |||
| "contacts.contact_filter", | |||
| "contacts.contact_history", | |||
| "contacts.contact_interrupt", | |||
There was a problem hiding this comment.
Editors should also be allowed as they can start flows as well
There was a problem hiding this comment.
Pretty weird that editors start flows. I wish we had a better line between them and admins. I think the only real difference is user management and billing.
There was a problem hiding this comment.
correct, everything else is the same except user management and billing
There was a problem hiding this comment.
I don't think that's true - editors don't have access to much of workspace administration. I also don't think it would be particularly useful to have a role which can edit flows but not use them.
There was a problem hiding this comment.
I've given the perm to editors and honestly I think we should expand that to agents too when this stuff is accessible from the ticket view because they'll probably need to be the people who pull contacts out of flows.
Requires https://github.com/nyaruka/mailroom/pull/643