Don't fetch manifest when all threads is set #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bmulholland is attempting to deploy a commit to the Nylas Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AaronDDM
requested review from
yifanplanet,
a team and
pooja169usp
and removed request for
a team
yifanplanet
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes
We include a fully stubbed-out/mocked-out instance of the mailbox component in our Storybook code. We then use Chromatic to take snapshots of it. This way, when we update the component, we'll get a visual comparison of any UI changes. It will help us upgrade our components quickly and easily, while still knowing if our UI will change somehow.
However, despite us supplying external data with
all_threads, the component still makes an HTTP request to Nylas, requiring both a component ID and Nylas Access Token. We don't want to expose a secret token to access a mailbox to our CI and Storybook; to date, our frontend has zero secrets that cannot be exposed to the frontend. We'd like to keep it that way.This change simply skips the manifest loading when all_threads is set. None of the manifest data would use used in this situation, anyway.
Readiness checklist
CHANGELOG.mdcomponent/src/properties.jsonLicense
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.