Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Set execute bit for all users #121

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Docker: Set execute bit for all users #121

merged 2 commits into from
Apr 8, 2024

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Apr 7, 2024

It became an issue when I tried to build image locally and run as non-root user in container.

Copy link

coderabbitai bot commented Apr 7, 2024

Warning

Rate Limit Exceeded

@glensc has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 26 minutes and 50 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 9b31fad and 9492e5d.

Walkthrough

The recent modifications focus on refining the Docker setup for a Scala project. They introduce a .dockerignore file to streamline the build context and adjust the Dockerfile to enhance security and execution efficiency. The .dockerignore ensures only essential files are included, while the Dockerfile changes ensure scripts and binaries have appropriate permissions for execution within the container.

Changes

File(s) Change Summary
.dockerignore Introduced to exclude all files except build.sbt, docker/entrypoint.sh, project, and src.
docker/Dockerfile Adjusted file permissions with --chmod=755 for entrypoint.sh and set executable permissions for binaries in the stage directory.

🐇✨
In the realm of code, where the dockers reside,
A rabbit hopped in, with changes applied.
"Let's tidy this place, keep only what's prime,
And secure our scripts, for execution sublime.
With permissions so set, and files neatly ignored,
Our container sails smooth, its performance adored."
🚀🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 9b31fad and 49bf5f7.
Files selected for processing (2)
  • .dockerignore (1 hunks)
  • docker/Dockerfile (1 hunks)
Additional comments not posted (3)
.dockerignore (1)

1-6: The updates to the .dockerignore file are well-considered, effectively minimizing the Docker build context by selectively including only necessary files and directories. This approach enhances both build performance and security.

docker/Dockerfile (2)

8-8: The command to set executable permissions for binaries in the stage directory is correctly implemented, ensuring that the container can be run securely by non-root users.


16-17: The adjustments to entrypoint.sh, including setting executable permissions and ensuring Unix-compatible line endings, are well-executed. These changes enhance the script's usability across different environments and adhere to best practices for Docker deployments.

Copy link
Owner

@nylonee nylonee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally for me too, lgtm

@nylonee nylonee merged commit f8a7519 into main Apr 8, 2024
2 checks passed
@nylonee nylonee deleted the docker-exec branch April 8, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants