-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker: Set execute bit for all users #121
Conversation
Warning Rate Limit Exceeded@glensc has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 26 minutes and 50 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent modifications focus on refining the Docker setup for a Scala project. They introduce a Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (2)
- .dockerignore (1 hunks)
- docker/Dockerfile (1 hunks)
Additional comments not posted (3)
.dockerignore (1)
1-6
: The updates to the.dockerignore
file are well-considered, effectively minimizing the Docker build context by selectively including only necessary files and directories. This approach enhances both build performance and security.docker/Dockerfile (2)
8-8
: The command to set executable permissions for binaries in thestage
directory is correctly implemented, ensuring that the container can be run securely by non-root users.
16-17
: The adjustments toentrypoint.sh
, including setting executable permissions and ensuring Unix-compatible line endings, are well-executed. These changes enhance the script's usability across different environments and adhere to best practices for Docker deployments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works locally for me too, lgtm
It became an issue when I tried to build image locally and run as non-root user in container.