Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max/client pool #5188

Merged
merged 68 commits into from
Jan 14, 2025
Merged

Max/client pool #5188

merged 68 commits into from
Jan 14, 2025

Conversation

mfahampshire
Copy link
Contributor

@mfahampshire mfahampshire commented Nov 27, 2024 •
edited
Loading

Client pool to run as background process, keeps a configurable # of ephemeral clients in reserve to be quickly used to speed up situations where multiple clients are needed.

Todo

  • code example with mixnet module
  • add to mixnet module docs examples
  • client pool disconnect(): cancel token to disconnect clients in pool + stop creating new clients
  • documentation
    • client pool in general
    • update tcpproxy module examples
    • inline code docs
    • client_pool.rs
  • update FFI
  • proper token cancellation in examples
    • multistream
    • single

This change is Reviewable

@mfahampshire mfahampshire requested a review from octol as a code owner November 27, 2024 23:05
@vercel Vercel
Copy link

vercel bot commented Nov 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-nextra ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 3:08pm
nym-explorer ⬜️ Ignored (Inspect) Jan 14, 2025 3:08pm
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 3:08pm

@mfahampshire mfahampshire marked this pull request as draft November 27, 2024 23:10
@mfahampshire mfahampshire force-pushed the max/tcp-proxy-connection-pool branch 3 times, most recently from ca8c57e to 33ba53b Compare December 12, 2024 12:35
@mfahampshire mfahampshire marked this pull request as ready for review December 16, 2024 17:52
@mfahampshire mfahampshire mentioned this pull request Dec 16, 2024
Merged
1 task
@mfahampshire
Copy link
Contributor Author

https://github.com/nymtech/nym/actions/runs/12363737133/job/34505653549

build ci passing

durch
durch approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@durch durch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I feel like I could actually use this to build things :)

@mfahampshire mfahampshire mentioned this pull request Jan 8, 2025
Draft
12 tasks
@mfahampshire mfahampshire force-pushed the max/tcp-proxy-connection-pool branch from 949e1c1 to a83b7c6 Compare January 13, 2025 21:39
@mfahampshire mfahampshire merged commit e454d71 into develop Jan 14, 2025
11 of 12 checks passed
@mfahampshire mfahampshire deleted the max/tcp-proxy-connection-pool branch January 14, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durch durch durch approved these changes

@octol octol Awaiting requested review from octol octol is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfahampshire @durch @jstuczyn