Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max/client pool #5188

Open
wants to merge 68 commits into
base: develop
Choose a base branch
from
Open

Max/client pool #5188

wants to merge 68 commits into from
+926 −233

Conversation

mfahampshire
Copy link
Contributor

@mfahampshire mfahampshire commented Nov 27, 2024 •
edited
Loading

Client pool to run as background process, keeps a configurable # of ephemeral clients in reserve to be quickly used to speed up situations where multiple clients are needed.

Todo

  • code example with mixnet module
  • add to mixnet module docs examples
  • client pool disconnect(): cancel token to disconnect clients in pool + stop creating new clients
  • documentation
    • client pool in general
    • update tcpproxy module examples
    • inline code docs
    • client_pool.rs
  • update FFI
  • proper token cancellation in examples
    • multistream
    • single

This change is Reviewable

@mfahampshire mfahampshire requested a review from octol as a code owner November 27, 2024 23:05
@vercel Vercel
Copy link

vercel bot commented Nov 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-nextra ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 3:19pm
nym-explorer ⬜️ Ignored (Inspect) Dec 20, 2024 3:19pm
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 3:19pm

@mfahampshire mfahampshire marked this pull request as draft November 27, 2024 23:10
@mfahampshire mfahampshire force-pushed the max/tcp-proxy-connection-pool branch 2 times, most recently from 2c5f47d to ca8c57e Compare December 10, 2024 19:57
@mfahampshire
tcp conn tracker
32b93a1
@mfahampshire
small tweak to tcp tracker
76ef784
@mfahampshire
name change + specific inc and dec logging
0ec7b46
@mfahampshire
changed logging
900c224
@mfahampshire
tweak
280677a
@mfahampshire
tweak
093db33
@mfahampshire
tweak existing conn tracker logic
550fb68
@mfahampshire
make default decay const
05e1d31
@mfahampshire
first pass connpool
e494235
@mfahampshire
fix flipped lowerthan waiting for pool
f7ec66a
@mfahampshire
first pass disconnect
68c84e3
@mfahampshire
trying to get disconnect to remove from pool
d730e88
@mfahampshire
remove double accounting for moment
c2cfa81
@mfahampshire
remove comments and reduce logging verbosity
bb766ec
@mfahampshire
comments
129169e
@mfahampshire
removed a bunch of commenting from example
ebbca9f
@mfahampshire
removed a bunch of commenting from example
20103ea
@mfahampshire
err handling conpool start
4fbe9c0
@mfahampshire
added notes for next features
c718fa8
@mfahampshire
first version working
09de3a4
@mfahampshire
first pass spin out client_pool
eb3cf38
@mfahampshire
cancel token
8b18585
@mfahampshire
logging change
31c5c2d
@mfahampshire
minor tweaks
8769c37
@mfahampshire
bump default decay time
30d5593
@mfahampshire mfahampshire marked this pull request as ready for review December 16, 2024 17:52
@mfahampshire mfahampshire mentioned this pull request Dec 16, 2024
Open
2 tasks
@mfahampshire
Copy link
Contributor Author

https://github.com/nymtech/nym/actions/runs/12363737133/job/34505653549

build ci passing

durch
durch approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@durch durch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I feel like I could actually use this to build things :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durch durch durch approved these changes

@octol octol Awaiting requested review from octol octol is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfahampshire @durch @jstuczyn